Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-38012 META: Simplify moodle forms
  3. MDL-37959

Shortforms require aria attributes to announce changes to screen readers.

    Details

      Description

      Add aria=polite to collapsible fieldsets.

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

              Hide
              rajeshtaneja Rajesh Taneja added a comment -

              Thanks for fixing this Fred,

              Patch looks good. Although with this patch, aria-live attribute will be visible on non-js page as-well.
              Should you consider adding it via JS ?

              Show
              rajeshtaneja Rajesh Taneja added a comment - Thanks for fixing this Fred, Patch looks good. Although with this patch, aria-live attribute will be visible on non-js page as-well. Should you consider adding it via JS ?
              Hide
              fred Frédéric Massart added a comment -

              That's right, but as the classes collapsible, etc... are added regardless of the JS, I don't see any problem adding it here. The aria attribute only throws a message to the screen reader if the section changes (if I got it correctly), so without JS nothing will happen. Pushing for integration review. Thanks

              Show
              fred Frédéric Massart added a comment - That's right, but as the classes collapsible, etc... are added regardless of the JS, I don't see any problem adding it here. The aria attribute only throws a message to the screen reader if the section changes (if I got it correctly), so without JS nothing will happen. Pushing for integration review. Thanks
              Hide
              stronk7 Eloy Lafuente (stronk7) added a comment -

              The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

              TIA and ciao

              Show
              stronk7 Eloy Lafuente (stronk7) added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
              Hide
              damyon Damyon Wiese added a comment -

              Thanks Fred,

              This change looks good to me.

              Integrated to master.

              Show
              damyon Damyon Wiese added a comment - Thanks Fred, This change looks good to me. Integrated to master.
              Hide
              dmonllao David Monllaó added a comment -

              It passes

              Show
              dmonllao David Monllaó added a comment - It passes
              Hide
              damyon Damyon Wiese added a comment -

              This issue has been integrated upstream and is now available via git (and in some hours, via mirrors and downloads).

              Thanks for your contributions!

              Show
              damyon Damyon Wiese added a comment - This issue has been integrated upstream and is now available via git (and in some hours, via mirrors and downloads). Thanks for your contributions!

                People

                • Votes:
                  0 Vote for this issue
                  Watchers:
                  5 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:
                    Fix Release Date:
                    14/May/13