Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-37964

Provide enrol_user for PHPunit tests in 2.3 (backport of MDL-36703)

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.3.4
    • Fix Version/s: 2.3.5
    • Component/s: Unit tests
    • Labels:
    • Testing Instructions:
      1. Run phpunit lib/phpunit/tests/generator_test.php
      2. When finished praise Mark.
    • Affected Branches:
      MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_23_STABLE

      Description

      Rather than having to re-write a unit test for 2.3 as the enrol_user function is not supported, we should include it. This will make developers' life easier.

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

              Hide
              damyon Damyon Wiese added a comment -

              +1 to backport from me. The patch is low risk and we do want to backport unit tests.

              Show
              damyon Damyon Wiese added a comment - +1 to backport from me. The patch is low risk and we do want to backport unit tests.
              Hide
              nebgor Aparup Banerjee added a comment -

              are we skipping testing more combinations with this skipped 're-write a unit test' ? (yea this patch does seem low risk, i'm just querying what isn't (rather) being fixed). +0.33333..

              Show
              nebgor Aparup Banerjee added a comment - are we skipping testing more combinations with this skipped 're-write a unit test' ? (yea this patch does seem low risk, i'm just querying what isn't (rather) being fixed). +0.33333..
              Hide
              damyon Damyon Wiese added a comment -

              You can praise Mark here: http://www.markwebber.com/

              Show
              damyon Damyon Wiese added a comment - You can praise Mark here: http://www.markwebber.com/
              Hide
              poltawski Dan Poltawski added a comment -

              Integrated to 23, thanks Mark.

              Show
              poltawski Dan Poltawski added a comment - Integrated to 23, thanks Mark.
              Hide
              poltawski Dan Poltawski added a comment -

              CI server says yes

              Show
              poltawski Dan Poltawski added a comment - CI server says yes
              Hide
              damyon Damyon Wiese added a comment -

              Congratulations this fix has been added to Moodle!

              You may want to dedicate this issue to someone special on this Valentines day.

              Thanks!

              Show
              damyon Damyon Wiese added a comment - Congratulations this fix has been added to Moodle! You may want to dedicate this issue to someone special on this Valentines day. Thanks!

                People

                • Votes:
                  0 Vote for this issue
                  Watchers:
                  4 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:
                    Fix Release Date:
                    11/Mar/13