Details
-
Type:
Bug
-
Status: Closed
-
Priority:
Minor
-
Resolution: Fixed
-
Affects Version/s: 2.4.1
-
Component/s: Blocks
-
Labels:
-
Testing Instructions:
-
Affected Branches:MOODLE_24_STABLE
-
Fixed Branches:MOODLE_24_STABLE, MOODLE_25_STABLE
-
Pull from Repository:
-
Pull Master Branch:master_
MDL-37968 -
Pull Master Diff URL:
Description
Usually, hidden courses are displayed to teachers but are dimmed (greyed). However, in the Course overview bloc, they are outputed as available course. In the renderer.php, there is no check on the course Visible property.
I propose the following fix to the function course_overview of class block_course_overview_renderer :
Just before these (line ~105):
$attributes = array('title' => s($course->fullname));
|
if ($course->id > 0) {
|
|
$courseurl = new moodle_url('/course/view.php', array('id' => $course->id));
|
$coursefullname = format_string($course->fullname, true, $course->id);
|
|
$link = html_writer::link($courseurl, $coursefullname, $attributes);
|
$html .= $this->output->heading($link, 2, 'title');
|
} else {
|
$html .= $this->output->heading(html_writer::link(
|
new moodle_url('/auth/mnet/jump.php', array('hostid' => $course->hostid, 'wantsurl' => '/course/view.php?id='.$course->remoteid)),
|
format_string($course->shortname, true), $attributes) . ' (' . format_string($course->hostname) . ')', 2, 'title');
|
}
|
add these:
|
$linkcss = $course->visible ? "" : "dimmed";
|
$attributes = array('title' => s($course->fullname), 'class' => $linkcss);
|
This way, we have the hidden course greyed out.
Gliffy Diagrams
Attachments
Issue Links
- caused a regression
-
-
- Closed
-
Activity
- All
- Comments
- Work Log
- History
- Activity
- Links Hierarchy
The same issue exists for our installation. Confirming that your code change has successfully rectified it.
I just want to comment that I think this is a major bug. Faculty need a quick way to identify whether students can see a course. Note that, as of today, 6 people have voted this important.
Indeed this bug is very annoying for teachers as in course overview there currently is no way of figuring out if a course is available to students or not.
Before Moodle 2.4 dimming was handled by the print_overview() function in course/lib.php.
Jean-Daniel's fix works as expected.
This bug can also be fixed by adding three lines copied from the print_overview() function in course/lib.php to blocks/course_overview/renderer.php.
Here's the patch.
pushing up for integration - thanks to Heiko and Jean-Daniel for the patches and report.
The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.
TIA and ciao 
rebased.
Integrated to master, 25 and 24 - thanks a lot Dan
works fine, thanks
Thanks for your awesome work! This has now become a part of Moodle.
Closing as fixed!
I setup my git repository following the http://docs.moodle.org/dev/Git_for_developers. Hopefully, I did everything ok. I is easier to post a diff than copying-pasting lines of code... however, I don't know the next step, I don't seem to be able to change the status of this bug to ask for a peer review.