Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-37972

Assignment (2.2) "Upload Single" settings submission file link does not work

    Details

    • Testing Instructions:
      Hide
      1. Access a course as Student and make a submission for a Upload Single file type Assignment (2.2)
      2. Navigate to Settings Block > Assignment administration > Submission
      3. Observe that file name which was submitted is listed as a link
      4. Click on the link in attempt to download the file

      Expected Result:
      Successful download of the Submitted file

      Show
      Access a course as Student and make a submission for a Upload Single file type Assignment (2.2) Navigate to Settings Block > Assignment administration > Submission Observe that file name which was submitted is listed as a link Click on the link in attempt to download the file Expected Result: Successful download of the Submitted file
    • Affected Branches:
      MOODLE_23_STABLE, MOODLE_24_STABLE
    • Fixed Branches:
      MOODLE_24_STABLE, MOODLE_25_STABLE, MOODLE_26_STABLE, MOODLE_27_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-37972-master
    • Sprint:
      FRONTEND Sprint 7
    • Story Points (Obsolete):
      3
    • Sprint:
      FRONTEND Sprint 7

      Description

      In an "Upload Single" assignment 2.2 type the file submission link for a student found in the Settings block under Assignment Administration -> Submission is a broken link. When clicked the following error message is produced:

      "No valid arguments supplied"

      Stack Trace:
      line 435 of /lib/setuplib.php: moodle_exception thrown
      line 3192 of /lib/filelib.php: call to print_error()
      line 37 of /pluginfile.php: call to file_pluginfile()

      Steps to Recreate:

      1. Access a course as Student and make a submission for a Upload Single file type Assignment (2.2)
      2. Navigate to Settings Block > Assignment administration > Submission
      3. Observe that file name which was submitted is listed as a link
      4. Click on the link in attempt to download the file

      Expected Result:
      Successful download of the Submitted file

      Actual Result:
      Error message is rendered that "No valid arguments supplied"

        Gliffy Diagrams

          Issue Links

            Activity

            Hide
            sbc24 Sam Chaffee added a comment -

            Attaching git diff produced against Moodle 2.3.3.

            Show
            sbc24 Sam Chaffee added a comment - Attaching git diff produced against Moodle 2.3.3.
            Hide
            salvetore Michael de Raadt added a comment -

            Thanks for reporting that.

            I was able to reproduce the problem.

            I'll leave this to Damyon to triage.

            Show
            salvetore Michael de Raadt added a comment - Thanks for reporting that. I was able to reproduce the problem. I'll leave this to Damyon to triage.
            Hide
            damyon Damyon Wiese added a comment -

            Thanks Sam, this fix looks correct - I'll review this ASAP.

            Show
            damyon Damyon Wiese added a comment - Thanks Sam, this fix looks correct - I'll review this ASAP.
            Hide
            damyon Damyon Wiese added a comment -

            This issue was assigned to me automatically, however I will not be able to work on this issue in the immediate future. In order to create a truer sense of the state of this issue and to allow other developers to have chance to become involved, I am removing myself as the assignee of this issue.

            For more information, see http://docs.moodle.org/dev/Changes_to_issue_assignment

            Show
            damyon Damyon Wiese added a comment - This issue was assigned to me automatically, however I will not be able to work on this issue in the immediate future. In order to create a truer sense of the state of this issue and to allow other developers to have chance to become involved, I am removing myself as the assignee of this issue. For more information, see http://docs.moodle.org/dev/Changes_to_issue_assignment
            Hide
            skodak Petr Skoda added a comment -

            looks ok, +1

            Show
            skodak Petr Skoda added a comment - looks ok, +1
            Hide
            marina Marina Glancy added a comment -

            Thanks Jason, integrated in 2.4, 2.5, 2.6 and master

            Show
            marina Marina Glancy added a comment - Thanks Jason, integrated in 2.4, 2.5, 2.6 and master
            Hide
            fred Frédéric Massart added a comment - - edited

            Edit: I'm useless... sorry I tested on the wrong branch.

            Show
            fred Frédéric Massart added a comment - - edited Edit: I'm useless... sorry I tested on the wrong branch.
            Hide
            phalacee Jason Fowler added a comment -

            no problem Fred, had me worried for a second.

            Show
            phalacee Jason Fowler added a comment - no problem Fred, had me worried for a second.
            Hide
            fred Frédéric Massart added a comment -

            Passing, but I found and raised MDL-43438.

            Show
            fred Frédéric Massart added a comment - Passing, but I found and raised MDL-43438 .
            Hide
            damyon Damyon Wiese added a comment -

            Twas the week before Christmas,
            And all though HQ
            Devs were scrambling to finish peer review.
            They sent all their issues,
            and rushed out the door -
            "To the beach!" someone heard them roar!

            This issue has been released upstream. Thanks!

            Show
            damyon Damyon Wiese added a comment - Twas the week before Christmas, And all though HQ Devs were scrambling to finish peer review. They sent all their issues, and rushed out the door - "To the beach!" someone heard them roar! This issue has been released upstream. Thanks!

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                6 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  13/Jan/14

                  Agile