Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-37976

Missing global $DB in topics function

    Details

      Description

      Looks like format_topics::update_course_format_options is missing a global $DB at the top.

        Gliffy Diagrams

          Attachments

            Activity

            Hide
            bushido Mark Nielsen added a comment -

            Looks like other formats may have this, like weeks.

            Show
            bushido Mark Nielsen added a comment - Looks like other formats may have this, like weeks.
            Hide
            poltawski Dan Poltawski added a comment -

            Yeesh, this is not good, if only we had tests for it.

            Assigning to Marina.

            Show
            poltawski Dan Poltawski added a comment - Yeesh, this is not good, if only we had tests for it. Assigning to Marina.
            Hide
            marina Marina Glancy added a comment -

            sorry my bad.
            This code is only invoked when format without numsections is deleted and there are existing courses in this format that need to be converted to default format, which has sections. Described in testing instructions.

            Show
            marina Marina Glancy added a comment - sorry my bad. This code is only invoked when format without numsections is deleted and there are existing courses in this format that need to be converted to default format, which has sections. Described in testing instructions.
            Hide
            poltawski Dan Poltawski added a comment -

            Oops, this was integrated yesterday but I forgot to press the button

            Show
            poltawski Dan Poltawski added a comment - Oops, this was integrated yesterday but I forgot to press the button
            Hide
            salvetore Michael de Raadt added a comment -

            Test result: Success!

            Tested in 2.4 and Master in all DBs.

            Show
            salvetore Michael de Raadt added a comment - Test result: Success! Tested in 2.4 and Master in all DBs.
            Hide
            damyon Damyon Wiese added a comment -

            Congratulations this fix has been added to Moodle!

            You may want to dedicate this issue to someone special on this Valentines day.

            Thanks!

            Show
            damyon Damyon Wiese added a comment - Congratulations this fix has been added to Moodle! You may want to dedicate this issue to someone special on this Valentines day. Thanks!

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  11/Mar/13