Details
-
Type:
Bug
-
Status: Closed
-
Priority:
Critical
-
Resolution: Fixed
-
Affects Version/s: 2.4.1
-
Fix Version/s: 2.4.2
-
Component/s: Course
-
Labels:
-
Testing Instructions:
- Set default format to Topics
- Create course in Social format
- Go to Settings -> Plugins -> Course formats -> Manage course formats and delete Social format
- Make sure there are no errors
-
Difficulty:Easy
-
Affected Branches:MOODLE_24_STABLE
-
Fixed Branches:MOODLE_24_STABLE
-
Pull from Repository:
-
Pull 2.4 Branch:wip-
MDL-37976-MOODLE_24_STABLE -
Pull Master Branch:wip-
MDL-37976-master -
Pull Master Diff URL:
-
Rank:47751
Description
Looks like format_topics::update_course_format_options is missing a global $DB at the top.
Activity
Yeesh, this is not good, if only we had tests for it.
Assigning to Marina.
Show
Dan Poltawski
added a comment - Yeesh, this is not good, if only we had tests for it.
Assigning to Marina.
sorry my bad.
This code is only invoked when format without numsections is deleted and there are existing courses in this format that need to be converted to default format, which has sections. Described in testing instructions.
Show
Marina Glancy
added a comment - sorry my bad.
This code is only invoked when format without numsections is deleted and there are existing courses in this format that need to be converted to default format, which has sections. Described in testing instructions.
Oops, this was integrated yesterday but I forgot to press the button
Show
Dan Poltawski
added a comment - Oops, this was integrated yesterday but I forgot to press the button
Test result: 
Success!
Tested in 2.4 and Master in all DBs.
Show
Michael de Raadt
added a comment - Test result: Success!
Tested in 2.4 and Master in all DBs.
Congratulations this fix has been added to Moodle!
You may want to dedicate this issue to someone special on this Valentines day.
Thanks!
Show
Damyon Wiese
added a comment - Congratulations this fix has been added to Moodle!
You may want to dedicate this issue to someone special on this Valentines day.
Thanks!
Looks like other formats may have this, like weeks.