Moodle
  1. Moodle
  2. MDL-37976

Missing global $DB in topics function

    Details

    • Rank:
      47751

      Description

      Looks like format_topics::update_course_format_options is missing a global $DB at the top.

        Activity

        Hide
        Mark Nielsen added a comment -

        Looks like other formats may have this, like weeks.

        Show
        Mark Nielsen added a comment - Looks like other formats may have this, like weeks.
        Hide
        Dan Poltawski added a comment -

        Yeesh, this is not good, if only we had tests for it.

        Assigning to Marina.

        Show
        Dan Poltawski added a comment - Yeesh, this is not good, if only we had tests for it. Assigning to Marina.
        Hide
        Marina Glancy added a comment -

        sorry my bad.
        This code is only invoked when format without numsections is deleted and there are existing courses in this format that need to be converted to default format, which has sections. Described in testing instructions.

        Show
        Marina Glancy added a comment - sorry my bad. This code is only invoked when format without numsections is deleted and there are existing courses in this format that need to be converted to default format, which has sections. Described in testing instructions.
        Hide
        Dan Poltawski added a comment -

        Oops, this was integrated yesterday but I forgot to press the button

        Show
        Dan Poltawski added a comment - Oops, this was integrated yesterday but I forgot to press the button
        Hide
        Michael de Raadt added a comment -

        Test result: Success!

        Tested in 2.4 and Master in all DBs.

        Show
        Michael de Raadt added a comment - Test result: Success! Tested in 2.4 and Master in all DBs.
        Hide
        Damyon Wiese added a comment -

        Congratulations this fix has been added to Moodle!

        You may want to dedicate this issue to someone special on this Valentines day.

        Thanks!

        Show
        Damyon Wiese added a comment - Congratulations this fix has been added to Moodle! You may want to dedicate this issue to someone special on this Valentines day. Thanks!

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: