Missing global $DB in topics function

Details

Type: Bug
Status: Closed
Priority: Critical
Resolution: Fixed
Affects Version/s: 2.4.1
Fix Version/s: 2.4.2
Component/s: Course
Labels:

Testing Instructions:
1. Set default format to Topics
2. Create course in Social format
3. Go to Settings -> Plugins -> Course formats -> Manage course formats and delete Social format
4. Make sure there are no errors
Difficulty:
Easy
Affected Branches:
MOODLE_24_STABLE
Fixed Branches:
MOODLE_24_STABLE
Pull from Repository:
git://github.com/marinaglancy/moodle.git
Pull 2.4 Branch:
wip-~~MDL-37976~~-MOODLE_24_STABLE
Pull 2.4 Diff URL:
https://github.com/marinaglancy/moodle/compare/MOODLE_24_STABLE...wip-MDL-37976-MOODLE_24_STABLE
Pull Master Branch:
wip-~~MDL-37976~~-master
Pull Master Diff URL:
https://github.com/marinaglancy/moodle/compare/master...wip-MDL-37976-master

Description

Looks like format_topics::update_course_format_options is missing a global $DB at the top.

Activity

Ascending order - Click to sort in descending order

Hide

Permalink

Mark Nielsen added a comment - 11/Feb/13 11:57 PM

Looks like other formats may have this, like weeks.

Show

Mark Nielsen added a comment - 11/Feb/13 11:57 PM Looks like other formats may have this, like weeks.

Hide

Permalink

Dan Poltawski added a comment - 12/Feb/13 12:32 AM

Yeesh, this is not good, if only we had tests for it.

Assigning to Marina.

Show

Dan Poltawski added a comment - 12/Feb/13 12:32 AM Yeesh, this is not good, if only we had tests for it. Assigning to Marina.

Hide

Permalink

Marina Glancy added a comment - 12/Feb/13 2:00 AM

sorry my bad.
This code is only invoked when format without numsections is deleted and there are existing courses in this format that need to be converted to default format, which has sections. Described in testing instructions.

Show

Marina Glancy added a comment - 12/Feb/13 2:00 AM sorry my bad. This code is only invoked when format without numsections is deleted and there are existing courses in this format that need to be converted to default format, which has sections. Described in testing instructions.

Hide

Permalink

Dan Poltawski added a comment - 13/Feb/13 2:04 AM

Oops, this was integrated yesterday but I forgot to press the button

Show

Dan Poltawski added a comment - 13/Feb/13 2:04 AM Oops, this was integrated yesterday but I forgot to press the button

Hide

Permalink

Michael de Raadt added a comment - 13/Feb/13 6:33 AM

Test result: Success!

Tested in 2.4 and Master in all DBs.

Show

Michael de Raadt added a comment - 13/Feb/13 6:33 AM Test result: Success! Tested in 2.4 and Master in all DBs.

Hide

Permalink

Damyon Wiese added a comment - 14/Feb/13 7:31 AM

Congratulations this fix has been added to Moodle!

You may want to dedicate this issue to someone special on this Valentines day.

Thanks!

Show

Damyon Wiese added a comment - 14/Feb/13 7:31 AM Congratulations this fix has been added to Moodle! You may want to dedicate this issue to someone special on this Valentines day. Thanks!

People

Assignee:

Marina Glancy

Reporter:

Mark Nielsen

Integrator:

Dan Poltawski

Tester:

Michael de Raadt

Participants:

Damyon Wiese, Dan Poltawski, Marina Glancy, Mark Nielsen, Michael de Raadt

Vote (0)

Watch (4)

Dates

Created:

11/Feb/13 11:54 PM

Updated:

14/Feb/13 7:31 AM

Resolved:

14/Feb/13 7:31 AM

Agile

View on Board