Moodle
  1. Moodle
  2. MDL-37986

Upgrade "Invalid installation files detected" message to remove CVS indications

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.3.4, 2.4, 2.5
    • Fix Version/s: None
    • Component/s: Installation, Language
    • Labels:
    • Affected Branches:
      MOODLE_23_STABLE, MOODLE_24_STABLE, MOODLE_25_STABLE
    • Rank:
      47763

      Description

      CVS servers have been disconnected, so i think we should remove references to CVS in core_admin's upgradestalefilesinfo message.

        Issue Links

          Activity

          Hide
          Séverin Terrier added a comment -

          Changes made for Moodle 2.3 to 2.5 in http://lang.moodle.org/local/amos/contrib.php?id=5693

          Show
          Séverin Terrier added a comment - Changes made for Moodle 2.3 to 2.5 in http://lang.moodle.org/local/amos/contrib.php?id=5693
          Hide
          Séverin Terrier added a comment -

          We should perhaps also remove in local_moodleorg.php the strings 'downloadcvs' and 'downloadcvstitle'...

          Show
          Séverin Terrier added a comment - We should perhaps also remove in local_moodleorg.php the strings 'downloadcvs' and 'downloadcvstitle'...
          Hide
          Séverin Terrier added a comment -

          I've also started a discussion about removing CVS informations :
          https://moodle.org/mod/forum/discuss.php?d=225052

          Show
          Séverin Terrier added a comment - I've also started a discussion about removing CVS informations : https://moodle.org/mod/forum/discuss.php?d=225052
          Hide
          Helen Foster added a comment -

          Séverin, thanks for your report and your AMOS contribution. I have committed the changes to en_fix, and will be available in the en lang pack when en_fix is merged with it within a month.

          David, I've added you as a watcher, hoping you can help with removing strings from local_moodleorg.php.

          Show
          Helen Foster added a comment - Séverin, thanks for your report and your AMOS contribution. I have committed the changes to en_fix, and will be available in the en lang pack when en_fix is merged with it within a month. David, I've added you as a watcher, hoping you can help with removing strings from local_moodleorg.php.
          Hide
          Dan Poltawski added a comment -

          Hmm, i'm not quite sure how local_moodleorg strings are getting into amos at the moment.

          Show
          Dan Poltawski added a comment - Hmm, i'm not quite sure how local_moodleorg strings are getting into amos at the moment.
          Hide
          David Mudrak added a comment -

          IIRC local_moodleorg is being imported into AMOS manually by myself per-demand. It's the same for all plugins managed by HQ that are not being published in moodle.org/plugins.

          Show
          David Mudrak added a comment - IIRC local_moodleorg is being imported into AMOS manually by myself per-demand. It's the same for all plugins managed by HQ that are not being published in moodle.org/plugins.
          Hide
          Helen Foster added a comment -

          David, please could you resolve this issue when the strings are removed from local_moodleorg.

          Show
          Helen Foster added a comment - David, please could you resolve this issue when the strings are removed from local_moodleorg.
          Hide
          David Mudrak added a comment -

          This issue was assigned to me, however I will not be able to work on this issue in the immediate future. In order to create a truer sense of the state of this issue and to allow other developers to have chance to become involved, I am removing myself as the assignee of this issue. For more information, see http://docs.moodle.org/dev/Changes_to_issue_assignment

          Show
          David Mudrak added a comment - This issue was assigned to me, however I will not be able to work on this issue in the immediate future. In order to create a truer sense of the state of this issue and to allow other developers to have chance to become involved, I am removing myself as the assignee of this issue. For more information, see http://docs.moodle.org/dev/Changes_to_issue_assignment
          Hide
          Petr Škoda added a comment -

          I did not find any CVS leftovers in master or local_moodleorg repo, closing. thanks

          Show
          Petr Škoda added a comment - I did not find any CVS leftovers in master or local_moodleorg repo, closing. thanks
          Hide
          Séverin Terrier added a comment -

          For what i can see in AMOS, local_moodleorg is for 2.3 ONLY, and still have the strings 'downloadcvs' and 'downloadcvstitle'. Don't know if it's correct/usefull/useless...

          Show
          Séverin Terrier added a comment - For what i can see in AMOS, local_moodleorg is for 2.3 ONLY, and still have the strings 'downloadcvs' and 'downloadcvstitle'. Don't know if it's correct/usefull/useless...
          Hide
          David Mudrak added a comment -

          The "downloadviagitcvs" string was replaced with the "downloadviagit" one by Dan on Mon Jan 21 08:49:27 2013 +0800 in the local_moodleorg plugin repository. The "downloadcvstitle" string was removed by Dan on Thu Mar 22 11:03:09 2012 +0800 there. So the only thing is that the plugin's strings were not updated in AMOS for a long time. I am going to do it now.

          Show
          David Mudrak added a comment - The "downloadviagitcvs" string was replaced with the "downloadviagit" one by Dan on Mon Jan 21 08:49:27 2013 +0800 in the local_moodleorg plugin repository. The "downloadcvstitle" string was removed by Dan on Thu Mar 22 11:03:09 2012 +0800 there. So the only thing is that the plugin's strings were not updated in AMOS for a long time. I am going to do it now.
          Hide
          David Mudrak added a comment -

          Done. The "local_moodleorg" component now appears to be at the 2.5 branch and it has the current strings registered only.

          Show
          David Mudrak added a comment - Done. The "local_moodleorg" component now appears to be at the 2.5 branch and it has the current strings registered only.
          Hide
          Séverin Terrier added a comment -

          Thanks David, it's nice like that

          Show
          Séverin Terrier added a comment - Thanks David, it's nice like that

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: