[MDL-37988] Table header row not in thead section - Moodle Tracker

XML

Word

Printable

Affected Branches:
MOODLE_24_STABLE, MOODLE_25_STABLE
Fixed Branches:
MOODLE_25_STABLE
Pull from Repository:
git://github.com/mouneyrac/moodle.git
Pull Master Branch:
~~MDL-37988~~-master
Pull Master Diff URL:
https://github.com/mouneyrac/moodle/compare/moodle:master...MDL-37988-master
Testing Instructions:
Hide

Enrol some users into a course

Enable course completion in the course

Go to Course administration > Reports > Course completion

VERIFY: that the table html code contains thead and tbody.

VERIFY: that you can export in the two csv formats and that the format is correct

Go to Course administration > Reports > Activity completion

VERIFY: that the table html code contains thead and tbody.

VERIFY: that you can export in the two csv formats and that the format is correct
Show
Enrol some users into a course Enable course completion in the course Go to Course administration > Reports > Course completion VERIFY: that the table html code contains thead and tbody. VERIFY: that you can export in the two csv formats and that the format is correct Go to Course administration > Reports > Activity completion VERIFY: that the table html code contains thead and tbody. VERIFY: that you can export in the two csv formats and that the format is correct

Bootstrap styles tables on the basis that the first tr row of th tags is inside a thead tag. This is also general good practice.

Updating an old bug since Bootstrap is going into core and that makes this much more obvious.

Specific examples:

1. If you search for courses in course/search.php in edit mode it provides you with a table of results with associated actions.

2. Course -> Reports -> activity completion table

blocks

MDL-39341 Rename 'bootstrap' theme to 'bootstrapbase'

duplicates

MDL-34293 Table headings inside the tbody rather than the thead section

has a non-specific relationship to

MDL-31830 Replacement for the course and category management pages

Testing discovered

MDL-38929 Vertical text appears truncated in the clean theme

will help resolve

MDL-38074 META: existing issues in Moodle core that affect Bootstrap

MDL-43907 Make tables of data themeable

(1 will help resolve)

Participants:: CiBoT, Damyon Wiese, Dan Poltawski, David Scotson, Jérôme Mouneyrac, Martin Dougiamas, Paul Holden, Rajesh Taneja

Component watchers:: David Woloszyn, Huong Nguyen, Jake Dallimore, Meirza, Michael Hawkins, Raquel Ortega, Safat Shahin, Stevani Andolo, Amaia Anabitarte, Carlos Escobedo, Laurent David, Mikel Martín Corrales, Sabina Abellan, Sara Arjona (@sarjona), Huong Nguyen, Bas Brands, Mathew May