Moodle
  1. Moodle
  2. MDL-37997

Improve cache usage stats display in the footer

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.5
    • Fix Version/s: 2.5
    • Component/s: Caching
    • Labels:
    • Testing Instructions:
      Hide

      Testing difficulty: Easy (although may require changes in config.php)

      1. Make sure MUC caches usage stats are displayed in the footer of your Moodle pages (you may need to define MDL_PERF and MDL_PERFTOFOOT constants in your config.php)
      2. Purge caches to force reloading of CSS
      3. Check the caches usage stats in the footer and make sure they look similar to the attached screenshot 02_new.png (actual number of caches may vary)
      Show
      Testing difficulty: Easy (although may require changes in config.php) Make sure MUC caches usage stats are displayed in the footer of your Moodle pages (you may need to define MDL_PERF and MDL_PERFTOFOOT constants in your config.php) Purge caches to force reloading of CSS Check the caches usage stats in the footer and make sure they look similar to the attached screenshot 02_new.png (actual number of caches may vary)
    • Affected Branches:
      MOODLE_25_STABLE
    • Fixed Branches:
      MOODLE_25_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-37997-muc-stats-display
    • Rank:
      47778

      Description

      Now as more and more MUC caches are being implemented, the current stats overview in the footer is getting less inspectional. It is getting rather long and it takes some time to detect caches with lower hits/misses ratio.

      1. 01_current.png
        60 kB
      2. 02_new.png
        53 kB
      3. 03_fixed_and_centered.png
        34 kB
      4. Screenshot from 2013-02-20.png
        116 kB
      5. Screenshot from 2013-02-20 2.png
        122 kB

        Issue Links

          Activity

          Hide
          David Mudrak added a comment -

          Attaching screenshots of the current look and the proposed improvement.

          In the new layout, cache stores with no hits and some misses are highlighted in red. Caches stores with some hits but more misses are highlighted in yellow. Otherwise (more hits than misses) the stores are highlighted in green.

          I believe this provides a nice quick overview over MUC performance.

          Show
          David Mudrak added a comment - Attaching screenshots of the current look and the proposed improvement. In the new layout, cache stores with no hits and some misses are highlighted in red. Caches stores with some hits but more misses are highlighted in yellow. Otherwise (more hits than misses) the stores are highlighted in green. I believe this provides a nice quick overview over MUC performance.
          Hide
          David Mudrak added a comment -

          Mike Delta Lima Tree Seven Niner Niner Seven, you are cleared to land.

          Show
          David Mudrak added a comment - Mike Delta Lima Tree Seven Niner Niner Seven, you are cleared to land.
          Hide
          Sam Hemelryk added a comment -

          Huge +1 from me, it looks fantastic thanks David. Will really help us poor devs as more and more caches arrive!

          Show
          Sam Hemelryk added a comment - Huge +1 from me, it looks fantastic thanks David. Will really help us poor devs as more and more caches arrive!
          Hide
          Sam Hemelryk added a comment -

          (and I'll be able to style it much more easily after this change. I like that very muchly as I'm battling with that right now)

          Show
          Sam Hemelryk added a comment - (and I'll be able to style it much more easily after this change. I like that very muchly as I'm battling with that right now)
          Hide
          Damyon Wiese added a comment -

          The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

          Thanks!

          Show
          Damyon Wiese added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. Thanks!
          Hide
          Dan Poltawski added a comment -

          Integrated, thanks

          Show
          Dan Poltawski added a comment - Integrated, thanks
          Hide
          Jason Fowler added a comment -

          The boxes are there, but they look awful on anything with a dark background for the footer

          To solve this all that needs doing is:

          add .performanceinfo .cachesused .cache-definition-stats

          { color: #000000; }

          to theme/base/style/core.css

          Show
          Jason Fowler added a comment - The boxes are there, but they look awful on anything with a dark background for the footer To solve this all that needs doing is: add .performanceinfo .cachesused .cache-definition-stats { color: #000000; } to theme/base/style/core.css
          Hide
          Jason Fowler added a comment -

          Another screenshot where the boxes make everything look awful

          Show
          Jason Fowler added a comment - Another screenshot where the boxes make everything look awful
          Hide
          David Mudrak added a comment -

          Very well caught Jason! Thanks a lot. (This is that moment when I really appreciate tester's work a lot). Going to look at it. Will try the solution suggested by Jason above.

          Show
          David Mudrak added a comment - Very well caught Jason! Thanks a lot. (This is that moment when I really appreciate tester's work a lot). Going to look at it. Will try the solution suggested by Jason above.
          Hide
          David Mudrak added a comment -

          I have reworked the CSS styling a bit yet. This round, I tried harder to use inline-display instead of float (did not work much initially but I finally sorted it out). So it seems to work acceptably in most standard themes.

          I realized that theme_binarius is using its own naming convection #footer instead of #page-footer so it does not look well in this theme. But I think the theme maintainer might want to fix this at the first place so I am not providing a solution for it at the moment.

          DEAR INTEGRATORS,

          I have added one additional commit 24798e5df5c9b5a472288afb884264f7ac20194f on top of the previously submitted branch. Please cherry-pick it or re-merge the branch to get the result.

          Thanks Jason again for catching this.

          Show
          David Mudrak added a comment - I have reworked the CSS styling a bit yet. This round, I tried harder to use inline-display instead of float (did not work much initially but I finally sorted it out). So it seems to work acceptably in most standard themes. I realized that theme_binarius is using its own naming convection #footer instead of #page-footer so it does not look well in this theme. But I think the theme maintainer might want to fix this at the first place so I am not providing a solution for it at the moment. DEAR INTEGRATORS, I have added one additional commit 24798e5df5c9b5a472288afb884264f7ac20194f on top of the previously submitted branch. Please cherry-pick it or re-merge the branch to get the result. Thanks Jason again for catching this.
          Hide
          David Mudrak added a comment -

          Attaching a screenshot that illustrates how it looks like with the colours and positioning fixed.

          Show
          David Mudrak added a comment - Attaching a screenshot that illustrates how it looks like with the colours and positioning fixed.
          Hide
          Dan Poltawski added a comment -

          Thanks David, i've integrated this now.

          Jason - can it be retested (don't forget the cache purge)

          thanks

          Show
          Dan Poltawski added a comment - Thanks David, i've integrated this now. Jason - can it be retested (don't forget the cache purge) thanks
          Hide
          Jason Fowler added a comment -

          All good now David, all though as you say, the Binarius theme needs work

          Show
          Jason Fowler added a comment - All good now David, all though as you say, the Binarius theme needs work
          Hide
          Damyon Wiese added a comment -

          Thanks for your hard work - this issue has made it! Moodle is now a little bit better.

          Regards, Damyon

          Show
          Damyon Wiese added a comment - Thanks for your hard work - this issue has made it! Moodle is now a little bit better. Regards, Damyon

            People

            • Votes:
              1 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: