Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-38000

CSS file names aren't handled consistently between request and delivery

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.4.1
    • Fix Version/s: 2.3.5, 2.4.2
    • Component/s: Themes
    • Labels:
    • Testing Instructions:
      Hide
      1. Create a new theme based upon standard.
      2. Create a config file and within it define the minimum.
      3. Create a file theme/yourthemename/test.css and set to it: body {background-color:red !important}
      4. In your config file add "$THEME->sheets = array('../test');
      5. Browse to your site and switch to your theme.
      6. Enable theme designer mode if it is not already enabled.
      7. Purge your caches.
      8. Inspect the source for the CSS and check that the CSS from the test file was loaded correctly.
      Show
      Create a new theme based upon standard. Create a config file and within it define the minimum. Create a file theme/yourthemename/test.css and set to it: body {background-color:red !important} In your config file add "$THEME->sheets = array('../test'); Browse to your site and switch to your theme. Enable theme designer mode if it is not already enabled. Purge your caches. Inspect the source for the CSS and check that the CSS from the test file was loaded correctly.
    • Affected Branches:
      MOODLE_24_STABLE
    • Fixed Branches:
      MOODLE_23_STABLE, MOODLE_24_STABLE
    • Pull Master Branch:
      wip-MDL-38000-m25

      Description

      This is an obscure we bug that I hit while looking at how to include CSS from a 3rd party library within the theme directory but not within the theme/style directory.

      To replicate:

      1. Create a new theme based upon standard.
      2. Create a config file and within it define the minimum.
      3. Create a file theme/yourthemename/test.css and set to it: body {background-color:red !important}
      4. In your config file add "$THEME->sheets = array('../test');
      5. Browse to your site and switch to your theme.
      6. Inspect the source for the CSS and note there was an issue.

        Attachments

          Activity

            People

            Assignee:
            samhemelryk Sam Hemelryk
            Reporter:
            samhemelryk Sam Hemelryk
            Peer reviewer:
            Mary Evans
            Integrator:
            Damyon Wiese
            Tester:
            David Monllaó
            Participants:
            Component watchers:
            Bas Brands
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              11/Mar/13