Moodle
  1. Moodle
  2. MDL-38001

Change community finder download button for install button

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.5
    • Fix Version/s: 2.5
    • Component/s: Hub
    • Labels:
    • Rank:
      47782

      Description

      I missed to change the Download button into Install button when I created a new string in https://tracker.moodle.org/browse/MDL-37012 during a post-review fix.

        Issue Links

          Activity

          Hide
          Jérôme Mouneyrac added a comment -

          Note: I kept the Download string, it's a pretty common string, I feel bad for translator to remove it. I don't know if we will change our mind again, I don't want to make the translator work more than they should if we revert it.

          Show
          Jérôme Mouneyrac added a comment - Note: I kept the Download string, it's a pretty common string, I feel bad for translator to remove it. I don't know if we will change our mind again, I don't want to make the translator work more than they should if we revert it.
          Hide
          Damyon Wiese added a comment -

          The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

          Thanks!

          Show
          Damyon Wiese added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. Thanks!
          Hide
          Helen Foster added a comment -

          I don't understand why the community finder download button should be changed to install, since when you click on it, the course backup file is downloaded. I've never heard of anyone saying it should be changed to install.

          Show
          Helen Foster added a comment - I don't understand why the community finder download button should be changed to install, since when you click on it, the course backup file is downloaded. I've never heard of anyone saying it should be changed to install.
          Hide
          Jérôme Mouneyrac added a comment -

          It makes sens as the button triggers a course installation (download being the first step). Martin suggested it when we reviewed the form. That's all

          Show
          Jérôme Mouneyrac added a comment - It makes sens as the button triggers a course installation (download being the first step). Martin suggested it when we reviewed the form. That's all
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Integrated (master), thanks!

          Show
          Eloy Lafuente (stronk7) added a comment - Integrated (master), thanks!
          Hide
          Helen Foster added a comment -

          Please reconsider whether this change is a good idea or not. Clicking the button does NOT install a course backup, it only downloads it, then a user has the choice of restoring the backup or not. If the button is changed to 'Install' then I think this will put a lot of people off.

          Show
          Helen Foster added a comment - Please reconsider whether this change is a good idea or not. Clicking the button does NOT install a course backup, it only downloads it, then a user has the choice of restoring the backup or not. If the button is changed to 'Install' then I think this will put a lot of people off.
          Hide
          Jérôme Mouneyrac added a comment - - edited

          In my opinion it makes sens to write "Install". If it was just a download action then we would not need to have the download feature in Moodle as MOOCH already offers it. Moreover, MOOCH does it better as the file is not stored in your private file but directly downloadable. I may miss a use case but at this moment, I don't see the point to have a backup file in private aera if it's not to install it.

          Show
          Jérôme Mouneyrac added a comment - - edited In my opinion it makes sens to write "Install". If it was just a download action then we would not need to have the download feature in Moodle as MOOCH already offers it. Moreover, MOOCH does it better as the file is not stored in your private file but directly downloadable. I may miss a use case but at this moment, I don't see the point to have a backup file in private aera if it's not to install it.
          Hide
          Rossiani Wijaya added a comment -

          Hi Jerome,

          This is working as expected.

          However, I have to a agree with Helen to keep the button as download instead of install. That way it has the consistency with the find select option value 'course I can download'. Maybe the button can be named 'download & install'? I will leave it up to you Jerome to decide.

          Test passed.

          Show
          Rossiani Wijaya added a comment - Hi Jerome, This is working as expected. However, I have to a agree with Helen to keep the button as download instead of install. That way it has the consistency with the find select option value 'course I can download'. Maybe the button can be named 'download & install'? I will leave it up to you Jerome to decide. Test passed.
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Because

          A
          MARVELOUS
          A       U
          Z  YOU  P
          I  ARE  E
          N  PPL  R
          G       B
            TNKS! 
          

          Closing, ciao

          Show
          Eloy Lafuente (stronk7) added a comment - Because A MARVELOUS A U Z YOU P I ARE E N PPL R G B TNKS! Closing, ciao
          Hide
          Mary Cooch added a comment - - edited

          I do worry about this too. Regular teachers understand "download" but if they see "install" they are going to shy away from doing anything in case they "break" something. At a push, download and install, but not install on its own.

          Show
          Mary Cooch added a comment - - edited I do worry about this too. Regular teachers understand "download" but if they see "install" they are going to shy away from doing anything in case they "break" something. At a push, download and install, but not install on its own.
          Hide
          Jérôme Mouneyrac added a comment - - edited

          Let's see how much trouble it causes, 'Install' seems good to me. Teachers who can be scared to use "Install" probably would not have used restore either, making the download feature kind of useless. I think it's better to download a file directly from moodle.net than putting it in a private file area less easy to access.

          Show
          Jérôme Mouneyrac added a comment - - edited Let's see how much trouble it causes, 'Install' seems good to me. Teachers who can be scared to use "Install" probably would not have used restore either, making the download feature kind of useless. I think it's better to download a file directly from moodle.net than putting it in a private file area less easy to access.
          Hide
          Martin Dougiamas added a comment -

          I think 'install' is the closest single word that applies to what happens when you press it.

          If people really think Install is scary then I think "Download and install" is OK.

          Show
          Martin Dougiamas added a comment - I think 'install' is the closest single word that applies to what happens when you press it. If people really think Install is scary then I think "Download and install" is OK.

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: