Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-38011

Regression: localised role names support causes standard role name to disappear in manual course completion criteria

    Details

    • Testing Instructions:
      Hide

      Enable completion in advanced features
      Create course with completion enabled
      Add Completion Status block to course
      Enrol a user in the course

      Places to check roles are displayed correctly:

      • In course Completion Settings, under "Manual completion by"
      • In the course completion report (column headings)
      • Course Completion status block (when logged in as participant)
      • Course participant's details.php page (access by clicking link in status block as participant)
      Show
      Enable completion in advanced features Create course with completion enabled Add Completion Status block to course Enrol a user in the course Places to check roles are displayed correctly: In course Completion Settings, under "Manual completion by" In the course completion report (column headings) Course Completion status block (when logged in as participant) Course participant's details.php page (access by clicking link in status block as participant)
    • Affected Branches:
      MOODLE_24_STABLE
    • Fixed Branches:
      MOODLE_24_STABLE
    • Pull Master Branch:

      Description

      Support for localised role names seems to cause a regression in "Manual completion by" Course completion criteria

      Step to reproduce:

      • Moodle 2.4 latest weekly build, fresh install
      • enable completion and conditional activities
      • create a course, enable completion
      • access course completion tracking page
      • standard role name labels are missing from "Manual completion by" criteria box

      To verify it depends from standard role names:

      • access site role definition
      • add a custom role name for at least one of the role that can manual approve course completion
      • save role definition
      • return to the course completion tracking page
      • the custom role name now appears in the "Manual completion by" criteria box

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

                People

                • Votes:
                  0 Vote for this issue
                  Watchers:
                  5 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:
                    Fix Release Date:
                    13/May/13