Moodle
  1. Moodle
  2. MDL-38011

Regression: localised role names support causes standard role name to disappear in manual course completion criteria

    Details

    • Testing Instructions:
      Hide

      Enable completion in advanced features
      Create course with completion enabled
      Add Completion Status block to course
      Enrol a user in the course

      Places to check roles are displayed correctly:

      • In course Completion Settings, under "Manual completion by"
      • In the course completion report (column headings)
      • Course Completion status block (when logged in as participant)
      • Course participant's details.php page (access by clicking link in status block as participant)
      Show
      Enable completion in advanced features Create course with completion enabled Add Completion Status block to course Enrol a user in the course Places to check roles are displayed correctly: In course Completion Settings, under "Manual completion by" In the course completion report (column headings) Course Completion status block (when logged in as participant) Course participant's details.php page (access by clicking link in status block as participant)
    • Affected Branches:
      MOODLE_24_STABLE
    • Fixed Branches:
      MOODLE_24_STABLE
    • Pull Master Branch:

      Description

      Support for localised role names seems to cause a regression in "Manual completion by" Course completion criteria

      Step to reproduce:

      • Moodle 2.4 latest weekly build, fresh install
      • enable completion and conditional activities
      • create a course, enable completion
      • access course completion tracking page
      • standard role name labels are missing from "Manual completion by" criteria box

      To verify it depends from standard role names:

      • access site role definition
      • add a custom role name for at least one of the role that can manual approve course completion
      • save role definition
      • return to the course completion tracking page
      • the custom role name now appears in the "Manual completion by" criteria box

        Gliffy Diagrams

          Issue Links

            Activity

            Hide
            Michael de Raadt added a comment -

            Thanks for reporting that, Andrea.

            I was able to replicate the problem. I'm not sure what the cause is, but no role names are displayed unless they are custom role names are shown, even when other roles have the "moodle/course:markcomplete" permission.

            Show
            Michael de Raadt added a comment - Thanks for reporting that, Andrea. I was able to replicate the problem. I'm not sure what the cause is, but no role names are displayed unless they are custom role names are shown, even when other roles have the "moodle/course:markcomplete" permission.
            Hide
            Jason Fowler added a comment -

            [Y] Syntax
            [-] Output
            [Y] Whitespace
            [-] Language
            [-] Databases
            [Y] Testing
            [-] Security
            [-] Documentation
            [Y] Git
            [?] Sanity check

            You could probably put a deprecation debug message in get_title_detailed() as it is effectively deprecated in favour of get_title()

            Show
            Jason Fowler added a comment - [Y] Syntax [-] Output [Y] Whitespace [-] Language [-] Databases [Y] Testing [-] Security [-] Documentation [Y] Git [?] Sanity check You could probably put a deprecation debug message in get_title_detailed() as it is effectively deprecated in favour of get_title()
            Hide
            Aaron Barnes added a comment -

            Hi Jason,

            Thanks for that. get_title_detailed() isn't deprecated, it's part of the criteria interface.

            Cheers,
            Aaron

            Show
            Aaron Barnes added a comment - Hi Jason, Thanks for that. get_title_detailed() isn't deprecated, it's part of the criteria interface. Cheers, Aaron
            Hide
            Dan Poltawski added a comment -

            Petr Skoda another role name regression..

            Show
            Dan Poltawski added a comment - Petr Skoda another role name regression..
            Hide
            Dan Poltawski added a comment -

            Integrated to master and 24 - thanks Aaron

            Show
            Dan Poltawski added a comment - Integrated to master and 24 - thanks Aaron
            Hide
            Andrew Davis added a comment -

            I think this is all working as it should. Passing.

            Show
            Andrew Davis added a comment - I think this is all working as it should. Passing.
            Hide
            Dan Poltawski added a comment -

            Blooming Marvelous! It's time for a knees up - your changes are upstream!

            Thanks for making Moodle better!

            Toodle pip

            Show
            Dan Poltawski added a comment - Blooming Marvelous! It's time for a knees up - your changes are upstream! Thanks for making Moodle better! Toodle pip

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                5 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: