Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.4.1, 2.5
    • Fix Version/s: 2.4.2
    • Component/s: Usability
    • Labels:
    • Testing Instructions:
      Hide

      Test pre-requisites

      • Enable the following enrolment methods:
        • Cohort
        • Manual
        • Paypal
        • Self
      • Flush your cache

      Test steps

      1. Go to a course, and add a grouping.
      2. Make sure each of the icons of the grouping work, and have the adequate size.
      3. Go the the enrolment methods page.
      4. Look at the Dropdown "Add a method" and confirm that there is a margin between the label and the select box.
      5. Add each of the above enrolment methods if they're not displayed yet.
      6. Make sure each of the icons have the right size.

      The alignment is not good, that's a known issue

      Show
      Test pre-requisites Enable the following enrolment methods: Cohort Manual Paypal Self Flush your cache Test steps Go to a course, and add a grouping. Make sure each of the icons of the grouping work, and have the adequate size. Go the the enrolment methods page. Look at the Dropdown "Add a method" and confirm that there is a margin between the label and the select box. Add each of the above enrolment methods if they're not displayed yet. Make sure each of the icons have the right size. The alignment is not good, that's a known issue
    • Affected Branches:
      MOODLE_24_STABLE, MOODLE_25_STABLE
    • Fixed Branches:
      MOODLE_24_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-38031-master

      Description

      Wrong icon size

        Gliffy Diagrams

          Attachments

            Activity

            Hide
            fred Frédéric Massart added a comment -

            Fixed a wrong icon. I am conscious that the look of the icons is not very nice yet in the enrolment page, but this needs a big refactor of the 'action icons' in the admin section and should be taken care of in another issue. I also changed an unrelated CSS rule to add some margin between label and select boxes as I did for singleselect but I didn't think of urlselect.

            Show
            fred Frédéric Massart added a comment - Fixed a wrong icon. I am conscious that the look of the icons is not very nice yet in the enrolment page, but this needs a big refactor of the 'action icons' in the admin section and should be taken care of in another issue. I also changed an unrelated CSS rule to add some margin between label and select boxes as I did for singleselect but I didn't think of urlselect.
            Hide
            markn Mark Nelson added a comment -

            Hi Fred,

            Looks good to me.

            A few minor points -

            1. I personally like having spaces before and after "=>".
            2. enrol/self/lib.php - the line change here could be put onto two lines to make it more readable.
            3. You could use html_writer for the anchor tag in the file group/groupings.php.

            Regards,

            Mark

            Show
            markn Mark Nelson added a comment - Hi Fred, Looks good to me. A few minor points - I personally like having spaces before and after "=>". enrol/self/lib.php - the line change here could be put onto two lines to make it more readable. You could use html_writer for the anchor tag in the file group/groupings.php. Regards, Mark
            Hide
            fred Frédéric Massart added a comment -

            Thanks Mark, I've patch my patch and am pushing for integration. Cheers!

            Show
            fred Frédéric Massart added a comment - Thanks Mark, I've patch my patch and am pushing for integration. Cheers!
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            Integrated (24 & master), thanks!

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - Integrated (24 & master), thanks!
            Hide
            dmonllao David Monllaó added a comment -

            Tested in 24 and master, passing it according to the testing instructions. I've noticed the commented incorrect alignment and padding between enrolment methods edit options, but I can't find the related issue.

            Show
            dmonllao David Monllaó added a comment - Tested in 24 and master, passing it according to the testing instructions. I've noticed the commented incorrect alignment and padding between enrolment methods edit options, but I can't find the related issue.
            Hide
            damyon Damyon Wiese added a comment -

            Thanks for your hard work - this issue has made it! Moodle is now a little bit better.

            Regards, Damyon

            Show
            damyon Damyon Wiese added a comment - Thanks for your hard work - this issue has made it! Moodle is now a little bit better. Regards, Damyon

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  11/Mar/13