Moodle
  1. Moodle
  2. MDL-38040

Detect all CRLFs in core and clean them

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.3.4, 2.4.1, 2.5
    • Fix Version/s: 2.3.5, 2.4.2
    • Component/s: General, Libraries
    • Labels:
    • Testing Instructions:
      Hide
      • Verify that only changes @ EOL have been introduced by the patch:

      git diff --ignore-space-at-eol  commitid
      

      • verify whitespace jobs are back to green in CI servers.
      Show
      Verify that only changes @ EOL have been introduced by the patch: git diff --ignore-space-at-eol commitid verify whitespace jobs are back to green in CI servers.
    • Affected Branches:
      MOODLE_23_STABLE, MOODLE_24_STABLE, MOODLE_25_STABLE
    • Fixed Branches:
      MOODLE_23_STABLE, MOODLE_24_STABLE
    • Pull from Repository:
    • Pull Master Branch:

      Description

      While looking for information @ CONTRIB-4158, with some quick greps it was detected that we have a few CRLF terminations in core (ignoring imported libs, of course).

      This is about:

      1) Make the illegal_whitespace job to detect such CRLFs.
      2) Fix all the core ones.

      Ciao

        Gliffy Diagrams

          Issue Links

            Activity

            Show
            Eloy Lafuente (stronk7) added a comment - Note this comment: https://tracker.moodle.org/browse/CONTRIB-4158?focusedCommentId=203237&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-203237 (that may lead to another issue)
            Hide
            Dan Poltawski added a comment -

            Integrated and verified no changes but the EOL.

            Show
            Dan Poltawski added a comment - Integrated and verified no changes but the EOL.
            Hide
            Dan Poltawski added a comment -

            Passed.

            Show
            Dan Poltawski added a comment - Passed.
            Hide
            Damyon Wiese added a comment -

            Thanks for your hard work - this issue has made it! Moodle is now a little bit better.

            Regards, Damyon

            Show
            Damyon Wiese added a comment - Thanks for your hard work - this issue has made it! Moodle is now a little bit better. Regards, Damyon

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: