Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-38051

Annihilate all the CRLFs present in some question/fixtures...

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.3.4, 2.4.1
    • Fix Version/s: 2.3.5, 2.4.2
    • Component/s: Questions
    • Labels:
    • Testing Instructions:
      Hide

      1) Verify the patch only contains whitespace changes at EOL.

      git diff git diff --ignore-space-at-eol

      2) Verify all question tests pass.

      3) Verify that, once integrated, the CI servers are right now passing the "illegal whitespace" jobs.

      Show
      1) Verify the patch only contains whitespace changes at EOL. git diff git diff --ignore-space-at-eol 2) Verify all question tests pass. 3) Verify that, once integrated, the CI servers are right now passing the "illegal whitespace" jobs.
    • Affected Branches:
      MOODLE_23_STABLE, MOODLE_24_STABLE
    • Fixed Branches:
      MOODLE_23_STABLE, MOODLE_24_STABLE
    • Pull Master Branch:

      Description

      Ignited by CONTRIB-4158 and detected by MDL-38040, it was detected that some question/fixtures do contain CRLFs and can be safely transformed to proper LFs.

      (See https://tracker.moodle.org/browse/CONTRIB-4158?focusedCommentId=203237&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-203237 for more info)

      The offending files are under:

      +question/format/blackboard/tests/fixtures/
      +question/format/blackboard_six/tests/fixtures/
      +question/format/xml/tests/fixtures/

      So this issue is about to:

      1) Take rid of all those CRLFs by changing them to LFs.
      2) In the CI servers take those directories out from quarantine.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              jmvedrine Jean-Michel Vedrine
              Reporter:
              stronk7 Eloy Lafuente (stronk7)
              Peer reviewer:
              Eloy Lafuente (stronk7)
              Integrator:
              Dan Poltawski
              Tester:
              Dan Poltawski
              Participants:
              Component watchers:
              Tim Hunt, Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                11/Mar/13