Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-38052

formal_white header displays badly

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.5
    • Fix Version/s: 2.4.2, 2.5
    • Component/s: Themes
    • Labels:
    • Testing Instructions:
      Hide
      1. In at least IE9 and one other supported browser
      2. Select Formal White theme using the Theme selector and NOT by URL (this is important).
      3. Navigate to the Formal White settings page found at Site Administration > Appearance > Themes > Formal white.
      4. In the Custom Logo & Frontpage Logo settings add the url from the attached greenlandscape.jpg.

        https://tracker.moodle.org/secure/attachment/31338/greenlandscape.jpg
        

        (Save settings).

      5. If not already set, enable Theme Designer Mode in Theme settings. (Save settings).
      6. TEST to see that there is no gap between the page-header and the outer frame other than the white border that is there normally and that the logo sits nicely within it.
      7. Open a new browser tab and navigate back to Formal White settings page.
      8. Set 'Frame margin' to 50px. (Save settings).
      9. Go back to first browser tab and TEST that the login/logout and lang menu are still in the page header, relative to their surroundings.

      TEST in RTL language

      1. With the above settings in place, and everything looking correct, swap to a RTL language.
      2. TEST to see that the Login/logout (headermenu) has shifted to the left side and that the logo is right aligned. You will see this better with a screen resolution 1024px x 786px, or by floating the browser window and making it narrower.
      Show
      In at least IE9 and one other supported browser Select Formal White theme using the Theme selector and NOT by URL (this is important). Navigate to the Formal White settings page found at Site Administration > Appearance > Themes > Formal white. In the Custom Logo & Frontpage Logo settings add the url from the attached greenlandscape.jpg. https://tracker.moodle.org/secure/attachment/31338/greenlandscape.jpg (Save settings). If not already set, enable Theme Designer Mode in Theme settings. (Save settings). TEST to see that there is no gap between the page-header and the outer frame other than the white border that is there normally and that the logo sits nicely within it. Open a new browser tab and navigate back to Formal White settings page. Set 'Frame margin' to 50px. (Save settings). Go back to first browser tab and TEST that the login/logout and lang menu are still in the page header, relative to their surroundings. TEST in RTL language With the above settings in place, and everything looking correct, swap to a RTL language. TEST to see that the Login/logout (headermenu) has shifted to the left side and that the logo is right aligned. You will see this better with a screen resolution 1024px x 786px, or by floating the browser window and making it narrower.
    • Affected Branches:
      MOODLE_25_STABLE
    • Fixed Branches:
      MOODLE_24_STABLE, MOODLE_25_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-38052_master

      Description

      I recently found the header of formal_white no longer display as it was few months ago.
      Looking at the history of the theme I found that MDL-32806 seems to be origin of the problem.
      In spite of this, I see that the peer reviewer of that issue was me even if I have no memory at all of it.
      Anyway, the problem is well described by the attached two screen shots.
      The first shows the problem, the second the expected solution.
      What I really do not know is whether this fix goes to modify the RTL as improved by MDL-32806.

        Gliffy Diagrams

          Attachments

            Activity

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                6 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  11/Mar/13