Moodle
  1. Moodle
  2. MDL-38072

Remove Collapsed Topics contributed plugin code (js & css) from MyMobile theme

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Critical Critical
    • Resolution: Fixed
    • Affects Version/s: 2.5
    • Fix Version/s: 2.5
    • Component/s: Themes
    • Labels:
    • Testing Instructions:
      Hide
      1. Select MyMobile theme via theme selector
      2. With mobile device or simulator TEST to see that the MyMobile works OK in normal course pages (weeks/topic/ etc.,) but NOT necessarily contributed plugins as these should be fixed in the plugins themselves.
      Show
      Select MyMobile theme via theme selector With mobile device or simulator TEST to see that the MyMobile works OK in normal course pages (weeks/topic/ etc.,) but NOT necessarily contributed plugins as these should be fixed in the plugins themselves.
    • Affected Branches:
      MOODLE_25_STABLE
    • Fixed Branches:
      MOODLE_25_STABLE
    • Pull Master Branch:
    • Rank:
      47870

      Description

      Historically CSS & Javascript was added to MyMobile theme to fix a problem with Collapsed Topics, a contributed plugin. However with the rapid development of Moodle 2.3 and 2.4 this became increasingly difficult, and so it was agreed that the changes should be with Collapsed Topics rather than the MyMobile theme itself.

        Issue Links

          Activity

          Hide
          Dan Poltawski added a comment -

          Giving this one Damyon, since hes integrating the blocking issue.

          Show
          Dan Poltawski added a comment - Giving this one Damyon, since hes integrating the blocking issue.
          Hide
          Damyon Wiese added a comment -

          Waiting for feedback on the blocking issue.

          Show
          Damyon Wiese added a comment - Waiting for feedback on the blocking issue.
          Hide
          Damyon Wiese added a comment -

          Moving this one out of integration - can be resubmitted at the same time as the blocking issue.

          Show
          Damyon Wiese added a comment - Moving this one out of integration - can be resubmitted at the same time as the blocking issue.
          Hide
          CiBoT added a comment -

          Moving this reopened issue out from current integration. Please, re-submit it for integration once ready.

          Show
          CiBoT added a comment - Moving this reopened issue out from current integration. Please, re-submit it for integration once ready.
          Hide
          Mary Evans added a comment -

          Because of the current issues with MDL-33934 I am submitting this issue first. Then deal with MDL-33934 after this is integrated.

          Show
          Mary Evans added a comment - Because of the current issues with MDL-33934 I am submitting this issue first. Then deal with MDL-33934 after this is integrated.
          Hide
          Eloy Lafuente (stronk7) added a comment -

          The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

          TIA and ciao

          Show
          Eloy Lafuente (stronk7) added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
          Hide
          Mary Evans added a comment -

          REBASED

          Show
          Mary Evans added a comment - REBASED
          Hide
          Mary Evans added a comment -

          I am very worried that nothing seems to be happening here although looking at the activity history it appears to be in integration. I just don't want to lose time with this as it is critical if I am to fix MyMobile theme.

          Can someone tell me what's happening?

          Thanks

          Show
          Mary Evans added a comment - I am very worried that nothing seems to be happening here although looking at the activity history it appears to be in integration. I just don't want to lose time with this as it is critical if I am to fix MyMobile theme. Can someone tell me what's happening? Thanks
          Hide
          Aparup Banerjee added a comment -

          This has been integrated into master, sorry if this fell off any radar. (i'd like to know how though)

          ps: could you link any discussion here about the removal of support if available just ftr. (it does make sense)

          Show
          Aparup Banerjee added a comment - This has been integrated into master, sorry if this fell off any radar. (i'd like to know how though) ps: could you link any discussion here about the removal of support if available just ftr. (it does make sense)
          Hide
          Mary Evans added a comment - - edited

          Just added an link Aparup, to MDL-33934 where there has been a lot of discussion, testing, rejection which MDL-38072 is currently blocking progress.

          Thanks for clarifying the state of this with this issue.
          Much appreciated.

          Show
          Mary Evans added a comment - - edited Just added an link Aparup, to MDL-33934 where there has been a lot of discussion, testing, rejection which MDL-38072 is currently blocking progress. Thanks for clarifying the state of this with this issue. Much appreciated.
          Hide
          Mary Evans added a comment -

          Aparup, I have just found the original tracker MDL-33115 where all the works was done.

          Show
          Mary Evans added a comment - Aparup, I have just found the original tracker MDL-33115 where all the works was done.
          Hide
          Frédéric Massart added a comment -

          Test passed, thanks!

          Show
          Frédéric Massart added a comment - Test passed, thanks!
          Hide
          Aparup Banerjee added a comment -

          Thanks for the linking them up Mary

          Show
          Aparup Banerjee added a comment - Thanks for the linking them up Mary
          Hide
          Eloy Lafuente (stronk7) added a comment -

          This is valid for unlimited entries to the, soon to be unveiled, Moodle Codebase Gardens. It includes free access to all facilities.

          Personal and non-transferable to all assignees, reviewers and testers in this issue. Valid until switching to Blackboard (100000€ penalization will be applied).

          Thanks, closing as fixed!

          Show
          Eloy Lafuente (stronk7) added a comment - This is valid for unlimited entries to the, soon to be unveiled, Moodle Codebase Gardens. It includes free access to all facilities. Personal and non-transferable to all assignees, reviewers and testers in this issue. Valid until switching to Blackboard (100000€ penalization will be applied). Thanks, closing as fixed!
          Hide
          Mary Evans added a comment -

          Show
          Mary Evans added a comment -

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: