Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-38079

Hide "add question to activity" button using javascript

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide
      1. enable the activity feedback
      2. disable javascript
      3. create a new feedback instance
      4. go to the "Edit questions" page. There should be the "Add question to activity" button
      5. enable javascript
      6. reload this page. The button should be gone.
      Show
      enable the activity feedback disable javascript create a new feedback instance go to the "Edit questions" page. There should be the "Add question to activity" button enable javascript reload this page. The button should be gone.
    • Affected Branches:
      MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_23_STABLE, MOODLE_24_STABLE, MOODLE_25_STABLE, MOODLE_26_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-38079_master

      Description

      Replication steps:
      Assuming you have javascript turned on

      1. Create a course
      2. Add the feedback activity to the course
      3. Edit questions
      4. Select a question type from the drop down menu

      Expected: Item gets selected, click on "Add question to activity" to add activity

      Actual: Item gets selected and automatically added to the activity

      This makes the button redundant for browsers with javascript turned on and is a source for potential confusion. I understand why we need the button there when javascript is not enabled in the browser, is there any other consideration I'm missing here?

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              mr-russ Russell Smith
              Reporter:
              marcusboon Marcus Boon
              Integrator:
              Marina Glancy
              Tester:
              David Monllaó
              Participants:
              Component watchers:
              Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Sara Arjona (@sarjona), Víctor Déniz Falcón
              Votes:
              1 Vote for this issue
              Watchers:
              7 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                8/Jul/13