Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-38079

Hide "add question to activity" button using javascript

XMLWordPrintable

    • MOODLE_23_STABLE
    • MOODLE_23_STABLE, MOODLE_24_STABLE, MOODLE_25_STABLE, MOODLE_26_STABLE
    • MDL-38079_master
    • Hide
      1. enable the activity feedback
      2. disable javascript
      3. create a new feedback instance
      4. go to the "Edit questions" page. There should be the "Add question to activity" button
      5. enable javascript
      6. reload this page. The button should be gone.
      Show
      enable the activity feedback disable javascript create a new feedback instance go to the "Edit questions" page. There should be the "Add question to activity" button enable javascript reload this page. The button should be gone.

      Replication steps:
      Assuming you have javascript turned on

      1. Create a course
      2. Add the feedback activity to the course
      3. Edit questions
      4. Select a question type from the drop down menu

      Expected: Item gets selected, click on "Add question to activity" to add activity

      Actual: Item gets selected and automatically added to the activity

      This makes the button redundant for browsers with javascript turned on and is a source for potential confusion. I understand why we need the button there when javascript is not enabled in the browser, is there any other consideration I'm missing here?

        1. 0001-MDL-38079-feedback-Hide-redundant-button-with-js-ena.patch
          1 kB

            mr-russ Russell Smith
            marcusboon Marcus Boon
            Marina Glancy Marina Glancy
            David Monllaó David Monllaó
            Votes:
            1 Vote for this issue
            Watchers:
            7 Start watching this issue

              Created:
              Updated:
              Resolved:

                Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.