Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-37417 Question editing forms improvements
  3. MDL-38094

Question editing forms should not add more repeat elements until requested

    Details

    • Type: Sub-task
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.4
    • Fix Version/s: 2.5
    • Component/s: Questions
    • Labels:
    • Testing Instructions:
      Hide

      Go to the quesion bank in any course.

      For each of these question types repeat the following steps.

      • Multiple-choice
      • Short-answer
      • Numerical
      • Matching
      • The three Calculated question types

      1. Click to create a new question.
      2. Verify that there are a sensible number of blanks provded for you to input your choices / answers / units / subquestions.
      3. Write your question and save it.
      4. Re-edit the question.
      5. Click the 'Blanks for ... more ...' button.
      6. For some qtypes, do acutally add more things, and in other cases, leave the new fields blank, or even delete some of the existing things.
      7. Save the editing question.
      8. Click the edit icon again, and check the form, just to make sure your edits were saved accurately.

      Show
      Go to the quesion bank in any course. For each of these question types repeat the following steps. Multiple-choice Short-answer Numerical Matching The three Calculated question types 1. Click to create a new question. 2. Verify that there are a sensible number of blanks provded for you to input your choices / answers / units / subquestions. 3. Write your question and save it. 4. Re-edit the question. 5. Click the 'Blanks for ... more ...' button. 6. For some qtypes, do acutally add more things, and in other cases, leave the new fields blank, or even delete some of the existing things. 7. Save the editing question. 8. Click the edit icon again, and check the form, just to make sure your edits were saved accurately.
    • Affected Branches:
      MOODLE_24_STABLE
    • Fixed Branches:
      MOODLE_25_STABLE
    • Pull from Repository:
    • Pull Master Branch:

      Description

      Suppose you have a multiple choice question with 5 choices, and you click to edit it. Then the form will be displayed with space for 8 choices, as if the 'Blanks for 3 more choices' button had already been clicked once.

      This is almost always useless. Adding a new choice is a rare edit. In addition, some people have got confused by this, and it makes the form even more daunting that it needs to be.

      The down-side is that in the rare case when you want more choices, you have to click and wait for another page load.

      On balance, we should remove the extra fields until the add more button is clicked.

        Gliffy Diagrams

          Issue Links

            Activity

            Hide
            timhunt Tim Hunt added a comment -

            Col, does this look OK to you? (Both the concept and the code.)

            Show
            timhunt Tim Hunt added a comment - Col, does this look OK to you? (Both the concept and the code.)
            Hide
            timhunt Tim Hunt added a comment -

            I think this is OK, so submitting for integration anyway.

            Show
            timhunt Tim Hunt added a comment - I think this is OK, so submitting for integration anyway.
            Hide
            samhemelryk Sam Hemelryk added a comment -

            Thanks Tim, this has been integrated now

            Show
            samhemelryk Sam Hemelryk added a comment - Thanks Tim, this has been integrated now
            Hide
            rwijaya Rossiani Wijaya added a comment -

            This is working as expected.

            Test passed.

            Show
            rwijaya Rossiani Wijaya added a comment - This is working as expected. Test passed.
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            This is valid for unlimited entries to the, soon to be unveiled, Moodle Codebase Gardens. It includes free access to all facilities.

            Personal and non-transferable to all assignees, reviewers and testers in this issue. Valid until switching to Blackboard (100000€ penalization will be applied).

            Thanks, closing as fixed!

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - This is valid for unlimited entries to the, soon to be unveiled, Moodle Codebase Gardens. It includes free access to all facilities. Personal and non-transferable to all assignees, reviewers and testers in this issue. Valid until switching to Blackboard (100000€ penalization will be applied). Thanks, closing as fixed!

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  14/May/13