Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-38105

Allow negative score for rubric and change default grade calculation method

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      BEFORE UPGRADE

      1. create an assignment with rubric grading method, create rubric without 0-points levels
      2. grade some students using rubrics
      3. review students grades in gradebook, they should be calculated using this unintuitive method
      4. backup assignment and save backup file for later
      5. upgrade
      6. open existing assignment, make sure the first option in the rubric (about locking 0-points) is not checked
      7. mark another student in this assignment
      8. make sure the grade calculation is the same as before
      9. create a new assignment with rubric grading, edit rubric
      10. make sure the 0-points is locked by default
      11. add the same criteria/levels as before
      12. grade students the same way as before
      13. check the grades in the gradebook, they should be calculated as: score / maxscore x maxgrade (where score is the total number of points in selected levels in the rubric; maxscore is the sum of maximum points for each criterion; maxgrade is whatever you set up in the module grade settings, usually 100)
      14. restore the assignment from the backup created before upgrade
      15. make sure the 0-points option is not checked there
      16. try editing the rubric without changing this option and make sure the option remains unchecked

      Regrading:

      1. Create an assignment with any rubric
      2. Grade some students
      3. As student make sure you can see rubric
      4. As teacher edit the rubric and change the flag "lock zero points"
      5. Make sure grades-have-changed confirmation is displayed
      6. Confirm
      7. As student make sure you can see grade but not rubric
      8. As a teacher open student grading again, it should be preserved, save grade
      9. As student make sure you can see grade and rubric (grade may have changed)

      Negative scores:

      1. Create an assignment with a rubric where some levels have negative number of points
      2. Grade students, some with positive and some with negative final scores
      3. Make sure the grade in the gradebook is max(0, score / maxscore x maxgrade)

      Changes to behat test:
      To ensure that the behavior did not change (despite the change in the behat test), do the following:

      1. Overwrite edit_rubric.feature with the version from upstream
      2. At line 32 add:

        | When converting rubric score to points/scale assume that minimum number of points is 0 |  |
        

      3. Run this test and make sure it passes
      Show
      BEFORE UPGRADE create an assignment with rubric grading method, create rubric without 0-points levels grade some students using rubrics review students grades in gradebook, they should be calculated using this unintuitive method backup assignment and save backup file for later upgrade open existing assignment, make sure the first option in the rubric (about locking 0-points) is not checked mark another student in this assignment make sure the grade calculation is the same as before create a new assignment with rubric grading, edit rubric make sure the 0-points is locked by default add the same criteria/levels as before grade students the same way as before check the grades in the gradebook, they should be calculated as: score / maxscore x maxgrade (where score is the total number of points in selected levels in the rubric; maxscore is the sum of maximum points for each criterion; maxgrade is whatever you set up in the module grade settings, usually 100) restore the assignment from the backup created before upgrade make sure the 0-points option is not checked there try editing the rubric without changing this option and make sure the option remains unchecked Regrading: Create an assignment with any rubric Grade some students As student make sure you can see rubric As teacher edit the rubric and change the flag "lock zero points" Make sure grades-have-changed confirmation is displayed Confirm As student make sure you can see grade but not rubric As a teacher open student grading again, it should be preserved, save grade As student make sure you can see grade and rubric (grade may have changed) Negative scores: Create an assignment with a rubric where some levels have negative number of points Grade students, some with positive and some with negative final scores Make sure the grade in the gradebook is max(0, score / maxscore x maxgrade) Changes to behat test: To ensure that the behavior did not change (despite the change in the behat test), do the following: Overwrite edit_rubric.feature with the version from upstream At line 32 add: | When converting rubric score to points/scale assume that minimum number of points is 0 | | Run this test and make sure it passes
    • Affected Branches:
      MOODLE_24_STABLE, MOODLE_28_STABLE
    • Fixed Branches:
      MOODLE_32_STABLE
    • Pull Master Branch:
      wip-MDL-38105-master
    • Sprint:
      3.2 Sprint 4

      Description

      Would be nice to allow negative grade in rubric. For example, this would allow teacher to set some penalty for bad grammar and orthography.

      I did look into the code and found two places where there is a comment "TODO why we can't allow negative score for rubric?"

      • /grade/grading/form/rubric/lib.php #206
      • /grade/grading/form/rubric/rubriceditor.php #215
        I tried to comment the validation and, if it now accept a negative value, the summary didn't compute correctly tho. I stop my investigation there as grades impact much of Moodle, and wasn't sure what else I could have broken.

        Attachments

          Issue Links

            Activity

              People

              • Votes:
                37 Vote for this issue
                Watchers:
                28 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  5/Dec/16