Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-38112

countries.php is missing some new counties (backport of MDL-35750)

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.2.7, 2.3.4, 2.4.3
    • Fix Version/s: 2.3.7, 2.4.4
    • Component/s: Language
    • Labels:
    • Testing Instructions:
      1. Use english language
      2. Edit your user profile
      3. Verify that the list of countries is working correctly and includes South Sudan, Spain, Australia, Curaçao
    • Affected Branches:
      MOODLE_22_STABLE, MOODLE_23_STABLE, MOODLE_24_STABLE
    • Fixed Branches:
      MOODLE_23_STABLE, MOODLE_24_STABLE

      Description

      In MDL-35750 I made the changes from ISO, but I hesitated about creating stable branches for it because we are removing a country.

      I propose I backport the patch but don't remove Netherlands Antilles

        Gliffy Diagrams

          Issue Links

            Activity

            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment - - edited

            My +1 to backport it to 23 & 24, keeping Netherlands Antilles (it will be reset it 2.5 upgrade if I don't remember wrongly).

            Ciao

            PS: I think this is pretty equivalent to timezones, for example, and we use to update those from time to time along all supported branches.

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - - edited My +1 to backport it to 23 & 24, keeping Netherlands Antilles (it will be reset it 2.5 upgrade if I don't remember wrongly). Ciao PS: I think this is pretty equivalent to timezones, for example, and we use to update those from time to time along all supported branches.
            Hide
            poltawski Dan Poltawski added a comment -

            Sending this for integration as a little birdy told me it might get voted through.

            Show
            poltawski Dan Poltawski added a comment - Sending this for integration as a little birdy told me it might get voted through.
            Hide
            damyon Damyon Wiese added a comment -

            The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

            Thanks!

            Show
            damyon Damyon Wiese added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. Thanks!
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            Hi Scott, I've raised your question @ MDLSITE-2188 so it will be verified/fixed there.

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - Hi Scott, I've raised your question @ MDLSITE-2188 so it will be verified/fixed there.
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            Integrated (23 & 24), thanks!

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - Integrated (23 & 24), thanks!
            Hide
            dmonllao David Monllaó added a comment -

            It passes, tested in 23 and 24

            Show
            dmonllao David Monllaó added a comment - It passes, tested in 23 and 24
            Hide
            poltawski Dan Poltawski added a comment -

            Did you remember to call thankDevelopers() for 'this_weeks_work'? Defaulting to PARAM_SHODDY thanking.

            line 1289 of \lib\changes.php: call to debugging()
            line 281 of \lib\are.php: call to moodleform->detectMissingThanks()
            line 202 of \lib\now.php: call to moodleform->_is_poor_form()
            line 73 of \course\upstream.php: call to moodleform->forgetingToThank()

            Show
            poltawski Dan Poltawski added a comment - Did you remember to call thankDevelopers() for 'this_weeks_work'? Defaulting to PARAM_SHODDY thanking. line 1289 of \lib\changes.php: call to debugging() line 281 of \lib\are.php: call to moodleform->detectMissingThanks() line 202 of \lib\now.php: call to moodleform->_is_poor_form() line 73 of \course\upstream.php: call to moodleform->forgetingToThank()

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  13/May/13