Moodle
  1. Moodle
  2. MDL-38141

Remove unnecessary dependency in modchooser

    Details

      Description

      We currently depend on the YUI transition module but we don't actually use it.
      This is an unnecessary page dependency which can increase load time.

        Gliffy Diagrams

          Activity

          Hide
          Andrew Nicols added a comment -

          Not exactly a massive change. What are thoughts WRT backporting to stable branches?

          Show
          Andrew Nicols added a comment - Not exactly a massive change. What are thoughts WRT backporting to stable branches?
          Hide
          Rajesh Taneja added a comment -

          Thanks Andrew, Patch looks spot-on.

          IMHO it's not important to backport this.

          Random case of some site with modified activity chooser with transition will break.

          [y] Syntax
          [y] Output
          [y] Whitespace
          [-] Language
          [-] Databases
          [y] Testing
          [-] Security
          [-] Documentation
          [y] Git
          [y] Sanity check

          Show
          Rajesh Taneja added a comment - Thanks Andrew, Patch looks spot-on. IMHO it's not important to backport this. Random case of some site with modified activity chooser with transition will break. [y] Syntax [y] Output [y] Whitespace [-] Language [-] Databases [y] Testing [-] Security [-] Documentation [y] Git [y] Sanity check
          Hide
          Damyon Wiese added a comment -

          The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

          Thanks!

          Show
          Damyon Wiese added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. Thanks!
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Integrated (master only), thanks!

          PS: I think we don't need to backport this, really. Although I'm open to think the opposite, lol.

          Show
          Eloy Lafuente (stronk7) added a comment - Integrated (master only), thanks! PS: I think we don't need to backport this, really. Although I'm open to think the opposite, lol.
          Hide
          Michael de Raadt added a comment -

          Test result: Success!

          Tested in FF (with and without JS), Chrome and IE. Tested in Master only.

          Show
          Michael de Raadt added a comment - Test result: Success! Tested in FF (with and without JS), Chrome and IE. Tested in Master only.
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Because

          A
          MARVELOUS
          A       U
          Z  YOU  P
          I  ARE  E
          N  PPL  R
          G       B
            TNKS! 
          

          Closing, ciao

          Show
          Eloy Lafuente (stronk7) added a comment - Because A MARVELOUS A U Z YOU P I ARE E N PPL R G B TNKS! Closing, ciao

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: