Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-38145

conditionlib_test inserts into DB directly rather than calling generator functions

    Details

      Description

      conditionlib_test should call API functions instead of inserting data directly. In this issue I only replace creating course category and course.
      This is necessary for MDL-37009 and course categories cache that is not aware about categories being inserted directly into DB

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

              Hide
              quen Sam Marshall added a comment -

              I had a look at the change, +1 from me.

              Note: The reason conditionlib_test workes how it does is that it was originally written before the generator functions existed.

              Show
              quen Sam Marshall added a comment - I had a look at the change, +1 from me. Note: The reason conditionlib_test workes how it does is that it was originally written before the generator functions existed.
              Hide
              damyon Damyon Wiese added a comment -

              The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

              Thanks!

              Show
              damyon Damyon Wiese added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. Thanks!
              Hide
              damyon Damyon Wiese added a comment -

              Hi Marina,

              Change looks good and the unit tests still pass for me.

              I have pushed this to master now.

              Thanks!

              Show
              damyon Damyon Wiese added a comment - Hi Marina, Change looks good and the unit tests still pass for me. I have pushed this to master now. Thanks!
              Hide
              abgreeve Adrian Greeve added a comment -

              I had a look at the code and it looks straight forward to me.
              Unit tests pass.
              Test passed.

              Show
              abgreeve Adrian Greeve added a comment - I had a look at the code and it looks straight forward to me. Unit tests pass. Test passed.
              Hide
              stronk7 Eloy Lafuente (stronk7) added a comment -

              Because

              A
              MARVELOUS
              A       U
              Z  YOU  P
              I  ARE  E
              N  PPL  R
              G       B
                TNKS! 
              

              Closing, ciao

              Show
              stronk7 Eloy Lafuente (stronk7) added a comment - Because A MARVELOUS A U Z YOU P I ARE E N PPL R G B TNKS! Closing, ciao

                People

                • Votes:
                  0 Vote for this issue
                  Watchers:
                  5 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:
                    Fix Release Date:
                    14/May/13