Moodle
  1. Moodle
  2. MDL-38180

Clicking user picture in enrol users dialog gives error.

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.4.1, 2.5
    • Fix Version/s: 2.4.4
    • Component/s: Enrolments
    • Labels:
    • Testing Instructions:
      Hide
      1. Go to any course
      2. Go to Course administration -> Users -> Enrolled Users
      3. Click on Enrol users
      4. Click on a picture of one of the users in the dialog
      5. Verify you see main profile if you have 'moodle/user:viewdetails' in system context
      6. Verify you do not see any picture link if you do not have 'moodle/user:viewdetails' in system context

      repeat for "other" users

      Show
      Go to any course Go to Course administration -> Users -> Enrolled Users Click on Enrol users Click on a picture of one of the users in the dialog Verify you see main profile if you have 'moodle/user:viewdetails' in system context Verify you do not see any picture link if you do not have 'moodle/user:viewdetails' in system context repeat for "other" users
    • Affected Branches:
      MOODLE_24_STABLE, MOODLE_25_STABLE
    • Fixed Branches:
      MOODLE_24_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      w12_MDL-38180_m25_enrolpics

      Description

      Enrol users dialog links to user course profile - but users are not enrolled yet (or they wouldn't be in the dialog).

      "Dwight Aldridge is not enrolled in this course".

      ( I think the solution is to make it not a link )

        Gliffy Diagrams

          Issue Links

            Activity

            Hide
            Petr Skoda added a comment -

            Thanks for the report.

            Show
            Petr Skoda added a comment - Thanks for the report.
            Hide
            Eloy Lafuente (stronk7) added a comment -

            Integrated (24 & master), thanks!

            Show
            Eloy Lafuente (stronk7) added a comment - Integrated (24 & master), thanks!
            Hide
            Rajesh Taneja added a comment -

            Thanks for fixing this Petr,

            Works fine for enrol user dialog.

            But clicking on image on "Enrolled users" page (In enrolled user table first name/surname) produce error

            You cannot view the profile of this user.
            

            Should this be also considered or is a different bug?

            Show
            Rajesh Taneja added a comment - Thanks for fixing this Petr, Works fine for enrol user dialog. But clicking on image on "Enrolled users" page (In enrolled user table first name/surname) produce error You cannot view the profile of this user. Should this be also considered or is a different bug?
            Hide
            Rajesh Taneja added a comment -

            Passing this test as course level capability check can be considered in another bug.

            Will raise another issue for it.

            Show
            Rajesh Taneja added a comment - Passing this test as course level capability check can be considered in another bug. Will raise another issue for it.
            Hide
            Damyon Wiese added a comment -

            This issue has been integrated upstream and is now available via git (and in some hours, via mirrors and downloads).

            Thanks for your contributions!

            Show
            Damyon Wiese added a comment - This issue has been integrated upstream and is now available via git (and in some hours, via mirrors and downloads). Thanks for your contributions!

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: