Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.3.4, 2.4.1, 2.5
    • Fix Version/s: 2.5
    • Component/s: Quiz
    • Labels:
      None
    • Testing Instructions:
      Hide

      Really, you need to test all parts of the quiz functionality, particularly the "Edit quiz" page, to make sure I have not introduced any regressions.

      Alternatively, you could try my "minify the JS before and after this change, and verify that the only changes are the removal of the o... and webkit... rules." approach.

      Hopefully there are no regressions, and if there are, the 2.5 MDLQA cycle will catch them all.

      Show
      Really, you need to test all parts of the quiz functionality, particularly the "Edit quiz" page, to make sure I have not introduced any regressions. Alternatively, you could try my "minify the JS before and after this change, and verify that the only changes are the removal of the o ... and webkit ... rules." approach. Hopefully there are no regressions, and if there are, the 2.5 MDLQA cycle will catch them all.
    • Affected Branches:
      MOODLE_23_STABLE, MOODLE_24_STABLE, MOODLE_25_STABLE
    • Fixed Branches:
      MOODLE_25_STABLE
    • Pull from Repository:
    • Pull Master Branch:
    • Rank:
      48050

      Description

      While reviewing MDL-38076 it was detected that CSS in quiz needs a cleanup.

      That includes:

      • line length / code formatting.
      • use of browser specific rules.
      • look / solve unnecessary rules @ theme/standard/style/css3.css

      Ciao

        Issue Links

          Activity

          Hide
          Tim Hunt added a comment -

          Doh! cleaning up the CSS in moodle/master was stupid. Merge conflicts, here we come.

          Show
          Tim Hunt added a comment - Doh! cleaning up the CSS in moodle/master was stupid. Merge conflicts, here we come.
          Hide
          Tim Hunt added a comment -

          OK. This is done as two commits:

          1. re-wrap the CSS to lay it out properly. To verify that this has not changed anything, I fed both the before and after code to http://www.cssminifier.com/, and verified that the minified result was the same.

          2. remove the propriatory CSS rules. I don't think they are needed any more.

          Show
          Tim Hunt added a comment - OK. This is done as two commits: 1. re-wrap the CSS to lay it out properly. To verify that this has not changed anything, I fed both the before and after code to http://www.cssminifier.com/ , and verified that the minified result was the same. 2. remove the propriatory CSS rules. I don't think they are needed any more.
          Hide
          Eloy Lafuente (stronk7) added a comment -

          The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

          TIA and ciao

          Show
          Eloy Lafuente (stronk7) added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
          Hide
          Aparup Banerjee added a comment -

          thanks Tim, integrated into master only.

          Show
          Aparup Banerjee added a comment - thanks Tim, integrated into master only.
          Hide
          Adrian Greeve added a comment -

          Tested on the master integration branch.
          The testing that I did, didn't reveal any errors or problems.
          Test passed.

          Show
          Adrian Greeve added a comment - Tested on the master integration branch. The testing that I did, didn't reveal any errors or problems. Test passed.
          Hide
          Mary Evans added a comment -

          Great!

          Show
          Mary Evans added a comment - Great!
          Hide
          Eloy Lafuente (stronk7) added a comment -

          This is valid for unlimited entries to the, soon to be unveiled, Moodle Codebase Gardens. It includes free access to all facilities.

          Personal and non-transferable to all assignees, reviewers and testers in this issue. Valid until switching to Blackboard (100000€ penalization will be applied).

          Thanks, closing as fixed!

          Show
          Eloy Lafuente (stronk7) added a comment - This is valid for unlimited entries to the, soon to be unveiled, Moodle Codebase Gardens. It includes free access to all facilities. Personal and non-transferable to all assignees, reviewers and testers in this issue. Valid until switching to Blackboard (100000€ penalization will be applied). Thanks, closing as fixed!

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: