Moodle
  1. Moodle
  2. MDL-38225

regression: database entries linked incorrectly (backport MDL-33603)

    Details

      Description

      Replication steps:-

      Add a few entries to a database module
      Make sure to include ##more## in your template so that you can see the more icon.
      Click on "view as list"
      Change the "Sort by" column and make sure that the first entry is different to the default. (clicking "Descending" should work)
      Click on any of the "more" icons

      Expected result:-
      It takes you to the correct page with the entry details

      Actual result:-
      It takes to a page with details of some random entry.

      Because of this issue all the databases on moodle.org are completely useless, such as Moodle Jobs, Moodle Buzz etc

      For example http://moodle.org/mod/data/view.php?d=50 , try accessing any package from that url.

        Gliffy Diagrams

          Issue Links

            Activity

            Hide
            Michael de Raadt added a comment -

            Thanks for championing this, Dan.

            Show
            Michael de Raadt added a comment - Thanks for championing this, Dan.
            Hide
            Adrian Greeve added a comment -

            Hi Dan,

            I've provided git branches for you. This is the same as the patch that is linked on the other issue. It's been well tested and works.

            Show
            Adrian Greeve added a comment - Hi Dan, I've provided git branches for you. This is the same as the patch that is linked on the other issue. It's been well tested and works.
            Hide
            Dan Poltawski added a comment -

            I'm happy to integrate and test this today if Dan Marsden gives a +1 (not too late).

            Show
            Dan Poltawski added a comment - I'm happy to integrate and test this today if Dan Marsden gives a +1 (not too late).
            Hide
            Dan Marsden added a comment -

            +1 from me if someone tests - not sure Dan is supposed to in HQ time though..

            Show
            Dan Marsden added a comment - +1 from me if someone tests - not sure Dan is supposed to in HQ time though..
            Hide
            Dan Poltawski added a comment -

            I'll take the risk.

            Show
            Dan Poltawski added a comment - I'll take the risk.
            Hide
            Dan Poltawski added a comment -

            Integrated and tested. Thanks a lot Adrian and Dan

            Show
            Dan Poltawski added a comment - Integrated and tested. Thanks a lot Adrian and Dan
            Hide
            Dan Poltawski added a comment -

            Tested and verified that the bug was there before the patch and that this fixes it.

            Show
            Dan Poltawski added a comment - Tested and verified that the bug was there before the patch and that this fixes it.
            Hide
            Séverin Terrier added a comment -

            Thanks Adrian and the 2 Dan for a better (and stable) 1.9.19+

            Show
            Séverin Terrier added a comment - Thanks Adrian and the 2 Dan for a better (and stable) 1.9.19+
            Hide
            Mike Churchward added a comment -

            Awesome guys! Thanks!

            Show
            Mike Churchward added a comment - Awesome guys! Thanks!
            Hide
            Eloy Lafuente (stronk7) added a comment -

            Because

            A
            MARVELOUS
            A       U
            Z  YOU  P
            I  ARE  E
            N  PPL  R
            G       B
              TNKS! 
            

            Closing, ciao

            Show
            Eloy Lafuente (stronk7) added a comment - Because A MARVELOUS A U Z YOU P I ARE E N PPL R G B TNKS! Closing, ciao

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                7 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: