Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-38230

Quiz access rules: Create UI for removing of access rule addons

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.4.1, 2.8.7, 2.9.1, 3.0
    • Fix Version/s: 2.8.8, 2.9.2
    • Component/s: Quiz
    • Labels:
    • Testing Instructions:
      Hide
      • Verify that going to Site Administration -> Plugin -> Plugin overview, no uninstall link is available for core quiz access rules
      • Install some third party quiz access rules available in the plugin directory https://moodle.org/plugins/browse.php?list=category&id=41 (I tested quizaccess_honestycheck, quizaccess_reattemptchecker, quizaccesspassgrade that don't need you to install anything else, I was too lazy to test quizaccess_safeexambrowser, quiraccess_supervizedcheck
      • as a teacher create a quiz with additional restrictions on attempts using the access rules you have installed (warning passgrade and reattemptchecker are currently buggy and need that you use the quiz rawgrade (sum of question grades) and not the quiz grade, so for instance if your quiz has 4 questions with 1 as grade each, set the "required grade" to 4 even if your quiz has a 10 as grade)
      • as a student attempt the quiz and verify that the rule massages are displayed (WARNING don't fails this issue is something seems wrong or odd in the access rule, we need to make some attempts as a student before and after removal of the attempt rule plugin just to verify nothing wrong happen, for instance the site is not broken after we remove the plugin as reported by a Moodle user in this forum thread: https://moodle.org/mod/forum/discuss.php?d=317239)
      • login as Administrator and going to Site Administration -> Plugins -> Plugins overview, verify that an uninstall link is displayed for each third party quiz access rule
      • uninstall these plugins
      • go to the quiz both as a teacher and as a student and verify nothing is broken
      Show
      Verify that going to Site Administration -> Plugin -> Plugin overview, no uninstall link is available for core quiz access rules Install some third party quiz access rules available in the plugin directory https://moodle.org/plugins/browse.php?list=category&id=41 (I tested quizaccess_honestycheck, quizaccess_reattemptchecker, quizaccesspassgrade that don't need you to install anything else, I was too lazy to test quizaccess_safeexambrowser, quiraccess_supervizedcheck as a teacher create a quiz with additional restrictions on attempts using the access rules you have installed (warning passgrade and reattemptchecker are currently buggy and need that you use the quiz rawgrade (sum of question grades) and not the quiz grade, so for instance if your quiz has 4 questions with 1 as grade each, set the "required grade" to 4 even if your quiz has a 10 as grade) as a student attempt the quiz and verify that the rule massages are displayed (WARNING don't fails this issue is something seems wrong or odd in the access rule, we need to make some attempts as a student before and after removal of the attempt rule plugin just to verify nothing wrong happen, for instance the site is not broken after we remove the plugin as reported by a Moodle user in this forum thread: https://moodle.org/mod/forum/discuss.php?d=317239 ) login as Administrator and going to Site Administration -> Plugins -> Plugins overview, verify that an uninstall link is displayed for each third party quiz access rule uninstall these plugins go to the quiz both as a teacher and as a student and verify nothing is broken
    • Affected Branches:
      MOODLE_24_STABLE, MOODLE_28_STABLE, MOODLE_29_STABLE, MOODLE_30_STABLE
    • Fixed Branches:
      MOODLE_28_STABLE, MOODLE_29_STABLE
    • Pull Master Branch:

      Description

      After reviewing https://moodle.org/plugins/view.php?plugin=quizaccess_honestycheck I realized there does not appear to be a way to remove access rule addons via the Moodle UI. Typically plugins provide a way to be removed. For example, consider the assignment submission plugins that provide mod/assign/adminmanageplugins.php?subtype=assignsubmission. I would expect something similar to allow for hiding a rule, managing any possible settings, and ultimately deleting the plugin.

      I suspect currently the expected practice would simply be to remove the code; however, the quizaccess_honesty table would remain in the database (which is not necessarily a problem if you want to provide a soft delete of the addon) but I would expect the table's data to be cleaned up.

      What is the ideal way for administering access rules? Would a site administration -> plugins page be helpful?

      Peace - Anthony

        Attachments

        1. ui001.png
          ui001.png
          41 kB
        2. ui002.png
          ui002.png
          38 kB

          Issue Links

            Activity

              People

              Assignee:
              timhunt Tim Hunt
              Reporter:
              aborrow Anthony Borrow
              Peer reviewer:
              Tim Hunt
              Integrator:
              Eloy Lafuente (stronk7)
              Tester:
              Adrian Greeve
              Participants:
              Component watchers:
              Tim Hunt, Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
              Votes:
              2 Vote for this issue
              Watchers:
              5 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                14/Sep/15