Moodle
  1. Moodle
  2. MDL-38238

Difficult to distinguish between t/lock and t/unlock icons

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.4.1
    • Fix Version/s: 2.5
    • Component/s: Themes
    • Labels:
    • Rank:
      48087

      Description

      This can best be seen on the Admin -> Plugins -> Manage blocks page. Can you tell the difference without squinting closely at the screen?

      These icons are used in a few other places too.

      (Fact of the day: On a clear day, a perigrine falcon can see a pigeon from about 5 miles away. http://wiki.answers.com/Q/Which_bird_has_the_best_sight)

      1. lock.svg
        0.9 kB
        Barbara Ramiro
      2. lock - final.svg
        1.0 kB
        Barbara Ramiro
      1. configlock.png
        0.4 kB
      2. hollow-locks.png
        7 kB
      3. lock.png
        0.2 kB
      4. lock - final.png
        0.3 kB
      5. locks.gif
        0.1 kB
      6. Lock-Unlock-icon.png
        8 kB
      7. manage_blocks.png
        11 kB
      8. permissionlock.png
        0.3 kB
      9. Screen Shot with the new lock icon.png
        10 kB
      10. unlock-lock.png
        1 kB
      11. unlock-lock2.png
        1 kB
      12. Wider-Opening.png
        10 kB

        Activity

        Hide
        Anthony Borrow added a comment -

        Tim - Fortunately I have reasonably good eyesight but I can see your point and hopefully this will hope others see it too. I think if they were to move the open position to the right side it would be more obvious right away. I'll see if I can find an good unlock image to show what I mean. Peace - Anthony

        Show
        Anthony Borrow added a comment - Tim - Fortunately I have reasonably good eyesight but I can see your point and hopefully this will hope others see it too. I think if they were to move the open position to the right side it would be more obvious right away. I'll see if I can find an good unlock image to show what I mean. Peace - Anthony
        Hide
        Anthony Borrow added a comment -

        Something more along the lines of would make it clearer

        Show
        Anthony Borrow added a comment - Something more along the lines of would make it clearer
        Hide
        Mary Evans added a comment -

        t/lock and t/unlocked are identical so too are t/unlock and t/locked

        Show
        Mary Evans added a comment - t/lock and t/unlocked are identical so too are t/unlock and t/locked
        Hide
        Helen Foster added a comment -

        I thought this problem was due to me getting old i.e. over 40.

        Show
        Helen Foster added a comment - I thought this problem was due to me getting old i.e. over 40.
        Hide
        Tim Hunt added a comment -

        I am saddened that Helen edited my amusing summary, but then perhaps it was only amusing to me.

        Show
        Tim Hunt added a comment - I am saddened that Helen edited my amusing summary, but then perhaps it was only amusing to me.
        Hide
        Anthony Borrow added a comment -

        Well I was amused and as I was adding this comment noticed the jira unlock icon (next to Viewable by All Users) is clearly an open lock. Peace - Anthony

        Show
        Anthony Borrow added a comment - Well I was amused and as I was adding this comment noticed the jira unlock icon (next to Viewable by All Users) is clearly an open lock. Peace - Anthony
        Hide
        Martin Dougiamas added a comment -

        We have a 12x12 limitation here so can't have it hanging out, but could perhaps make it more open and even turn it upside down?

        Alternatively, make the open one more "light" coloured, eg 50% dot-hatched.

        Show
        Martin Dougiamas added a comment - We have a 12x12 limitation here so can't have it hanging out, but could perhaps make it more open and even turn it upside down? Alternatively, make the open one more "light" coloured, eg 50% dot-hatched.
        Hide
        Barbara Ramiro added a comment -

        Anthony, you're proposal is good but it wont fit on 12x12 and we have to think of overall consistency as well (say for example t/locktime.png which uses the padlock).

        The image above is a bit open by 1px. Opening it more by 2px looks like an iron and 3px a radio with antenna.

        Show
        Barbara Ramiro added a comment - Anthony, you're proposal is good but it wont fit on 12x12 and we have to think of overall consistency as well (say for example t/locktime.png which uses the padlock). The image above is a bit open by 1px. Opening it more by 2px looks like an iron and 3px a radio with antenna.
        Hide
        Frédéric Massart added a comment -

        Hi Mary,

        I introduced the new icons t/locked and t/unlocked because it makes it easier to have a name based on what the icon represent rather than what the icon is supposed to do. We had (and probably still have) icons representing an unlocked paddlock, which has the action of locking and we were using t/lock. The same way, we had t/unlock_gray which is too describe, I suggested in the upgrade.txt file to use t/locked instead.

        I, perhaps, should have removed the entire use of t/(un)lock and add a note in the upgrade.txt so that we could deprecate them in the future.

        End of the story .

        Show
        Frédéric Massart added a comment - Hi Mary, I introduced the new icons t/locked and t/unlocked because it makes it easier to have a name based on what the icon represent rather than what the icon is supposed to do. We had (and probably still have) icons representing an unlocked paddlock, which has the action of locking and we were using t/lock. The same way, we had t/unlock_gray which is too describe, I suggested in the upgrade.txt file to use t/locked instead. I, perhaps, should have removed the entire use of t/(un)lock and add a note in the upgrade.txt so that we could deprecate them in the future. End of the story .
        Hide
        Martin Dougiamas added a comment -

        That's not enough IMO, Barbara, it's still hard to distinguish them.

        Show
        Martin Dougiamas added a comment - That's not enough IMO, Barbara, it's still hard to distinguish them.
        Hide
        Martin Dougiamas added a comment -

        Very rough sketch of a possibility

        Show
        Martin Dougiamas added a comment - Very rough sketch of a possibility
        Hide
        Martin Dougiamas added a comment -

        Added some hollow locks as an idea

        Show
        Martin Dougiamas added a comment - Added some hollow locks as an idea
        Hide
        Barbara Ramiro added a comment -

        What ya think? I hope it doesn't look like a bag and a swan on its own ha ha

        Show
        Barbara Ramiro added a comment - What ya think? I hope it doesn't look like a bag and a swan on its own ha ha
        Hide
        Barbara Ramiro added a comment -

        Just in case it looks like a swan, here's another version.

        Show
        Barbara Ramiro added a comment - Just in case it looks like a swan, here's another version.
        Hide
        Martin Dougiamas added a comment -

        +1 for the second handbag and swan.

        Show
        Martin Dougiamas added a comment - +1 for the second handbag and swan.
        Hide
        Frédéric Massart added a comment -

        +1 for Martin's hollow padlocks

        Show
        Frédéric Massart added a comment - +1 for Martin's hollow padlocks
        Hide
        Barbara Ramiro added a comment -

        Me too +1 for the hollow padlock

        Show
        Barbara Ramiro added a comment - Me too +1 for the hollow padlock
        Hide
        Barbara Ramiro added a comment - - edited

        Here it goes "lock - final.png"

        Show
        Barbara Ramiro added a comment - - edited Here it goes "lock - final.png"
        Hide
        Barbara Ramiro added a comment -


        Screen Shot with the new lock icon.png

        Show
        Barbara Ramiro added a comment - Screen Shot with the new lock icon.png
        Hide
        Martin Dougiamas added a comment - - edited

        Grumble, not sure why the bits are needed in the middle, they just make it look busy ... why not make it simpler if it works just as well? Yours sincerely, Steve Jobs

        Show
        Martin Dougiamas added a comment - - edited Grumble, not sure why the bits are needed in the middle, they just make it look busy ... why not make it simpler if it works just as well? Yours sincerely, Steve Jobs
        Hide
        Barbara Ramiro added a comment -

        That bit in the middle is to make it look more of a padlock than a bag. Also to make it look consistent with the other icons with padlock such as configlock.png and permissionlock.png

        Show
        Barbara Ramiro added a comment - That bit in the middle is to make it look more of a padlock than a bag. Also to make it look consistent with the other icons with padlock such as configlock.png and permissionlock.png
        Hide
        Dan Poltawski added a comment -

        Integrated to master. Visually verified distinction with svgicons on and off.

        Show
        Dan Poltawski added a comment - Integrated to master. Visually verified distinction with svgicons on and off.
        Hide
        Barbara Ramiro added a comment -

        Thanks Dan =)

        Show
        Barbara Ramiro added a comment - Thanks Dan =)
        Hide
        Eloy Lafuente (stronk7) added a comment -

        Did you think this day was not going to arrive ever?

        Your patience has been rewarded, yay, sent upstream, thanks!

        Closing...ciao

        Show
        Eloy Lafuente (stronk7) added a comment - Did you think this day was not going to arrive ever? Your patience has been rewarded, yay, sent upstream, thanks! Closing...ciao

          People

          • Votes:
            1 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: