Moodle
  1. Moodle
  2. MDL-37417 Question editing forms improvements
  3. MDL-38240

penalty should not be a required field on the question editing forms

    Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.5
    • Fix Version/s: 2.5
    • Component/s: Questions
    • Labels:
    • Testing Instructions:
      Hide

      1. Go to the question bank in any course.
      2. Click to create a question of any type. (If possible test a few.)
      3. Verify that 'Penalty' is not a required field.
      4. Hence verify that the 'Multiple tries' second of the form is collapsed by default.

      Show
      1. Go to the question bank in any course. 2. Click to create a question of any type. (If possible test a few.) 3. Verify that 'Penalty' is not a required field. 4. Hence verify that the 'Multiple tries' second of the form is collapsed by default.
    • Affected Branches:
      MOODLE_25_STABLE
    • Fixed Branches:
      MOODLE_25_STABLE
    • Pull from Repository:
    • Pull Master Branch:
    • Rank:
      48089

      Description

      It prevents the 'Settings for multiple tries' fieldset from collapsing.

      Also, it is a select drop-down, it is impossible for the field to be not set, and 0 is a vaid value, so altogether, making it not required is not an issue.

        Activity

        Hide
        Tim Hunt added a comment -

        Col, does this look OK to you? (Both the concept and the code.)

        Show
        Tim Hunt added a comment - Col, does this look OK to you? (Both the concept and the code.)
        Hide
        Tim Hunt added a comment -

        Sorry about the spam. I clicked the wrong button.

        Show
        Tim Hunt added a comment - Sorry about the spam. I clicked the wrong button.
        Hide
        Tim Hunt added a comment -

        I think this is OK, so submitting for integration anyway.

        Show
        Tim Hunt added a comment - I think this is OK, so submitting for integration anyway.
        Hide
        Aparup Banerjee added a comment -

        This seems to make sense, integrated into master.

        Show
        Aparup Banerjee added a comment - This seems to make sense, integrated into master.
        Hide
        Adrian Greeve added a comment -

        Tested on the master integration branch,
        Verified in multiple different question types that 'Penalty' was not a required field and that the 'multiple tries' area was collapsed.
        Test passed.

        Show
        Adrian Greeve added a comment - Tested on the master integration branch, Verified in multiple different question types that 'Penalty' was not a required field and that the 'multiple tries' area was collapsed. Test passed.
        Hide
        Eloy Lafuente (stronk7) added a comment -

        This is valid for unlimited entries to the, soon to be unveiled, Moodle Codebase Gardens. It includes free access to all facilities.

        Personal and non-transferable to all assignees, reviewers and testers in this issue. Valid until switching to Blackboard (100000€ penalization will be applied).

        Thanks, closing as fixed!

        Show
        Eloy Lafuente (stronk7) added a comment - This is valid for unlimited entries to the, soon to be unveiled, Moodle Codebase Gardens. It includes free access to all facilities. Personal and non-transferable to all assignees, reviewers and testers in this issue. Valid until switching to Blackboard (100000€ penalization will be applied). Thanks, closing as fixed!

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: