Details

    • Type: Sub-task
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.5
    • Fix Version/s: 2.5
    • Component/s: Workshop
    • Labels:
    • Testing Instructions:
      Hide

      Testing difficulty: easy

      1. Create workshop and define the assessment form consisting of at least four dimensions (aspects, criteria, ...). Ideally test this with all grading strategies available.
      2. Switch to the submission phase and make user to submit something.
      3. Switch to assessment phase and asses submission.
      4. TEST: Make sure there are no collapsed sections within the assessment form, that is the assessment form opens expanded by default.
      Show
      Testing difficulty: easy Create workshop and define the assessment form consisting of at least four dimensions (aspects, criteria, ...). Ideally test this with all grading strategies available. Switch to the submission phase and make user to submit something. Switch to assessment phase and asses submission. TEST: Make sure there are no collapsed sections within the assessment form, that is the assessment form opens expanded by default.
    • Affected Branches:
      MOODLE_25_STABLE
    • Fixed Branches:
      MOODLE_25_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-38243-master

      Description

      This is a regression of the recent improvements in mforms. When an assessment form in Workshop is loaded, only the first section (aspect, criterion, ...) is expanded. All others are collapsed. For assessment forms, we want them all expanded by default.

        Gliffy Diagrams

          Issue Links

            Activity

            Hide
            mudrd8mz David Mudrak added a comment -

            Attaching 001-regression.png that illustrates the issue.

            Show
            mudrd8mz David Mudrak added a comment - Attaching 001-regression.png that illustrates the issue.
            Hide
            timhunt Tim Hunt added a comment -

            Actually, David, that form is following the rules: For a form with three or more sections, the first is expanded, and the rest collapsed by default (unless they contain required fields).

            For this form, the defaults are not appropriate, so you need to add some calls to the new API, which if I remember rightly is ->setExpanded(...)

            Show
            timhunt Tim Hunt added a comment - Actually, David, that form is following the rules: For a form with three or more sections, the first is expanded, and the rest collapsed by default (unless they contain required fields). For this form, the defaults are not appropriate, so you need to add some calls to the new API, which if I remember rightly is ->setExpanded(...)
            Hide
            kabalin Ruslan Kabalin added a comment -

            $mform->setExpanded('headername') is for a single header, for the full form it is better to use $mform->setDisableShortforms()

            Show
            kabalin Ruslan Kabalin added a comment - $mform->setExpanded('headername') is for a single header, for the full form it is better to use $mform->setDisableShortforms()
            Hide
            kabalin Ruslan Kabalin added a comment -

            David, thanks for reporting this. The patch is attached, please review it.

            Show
            kabalin Ruslan Kabalin added a comment - David, thanks for reporting this. The patch is attached, please review it.
            Hide
            mudrd8mz David Mudrak added a comment -

            Nice and clean patch! Thanks Ruslan. +1

            Show
            mudrd8mz David Mudrak added a comment - Nice and clean patch! Thanks Ruslan. +1
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

            TIA and ciao

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
            Hide
            samhemelryk Sam Hemelryk added a comment -

            Thanks guys, this has been integrated now.

            Show
            samhemelryk Sam Hemelryk added a comment - Thanks guys, this has been integrated now.
            Hide
            phalacee Jason Fowler added a comment -

            All good Ruslan, thanks.

            Show
            phalacee Jason Fowler added a comment - All good Ruslan, thanks.
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            This is valid for unlimited entries to the, soon to be unveiled, Moodle Codebase Gardens. It includes free access to all facilities.

            Personal and non-transferable to all assignees, reviewers and testers in this issue. Valid until switching to Blackboard (100000€ penalization will be applied).

            Thanks, closing as fixed!

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - This is valid for unlimited entries to the, soon to be unveiled, Moodle Codebase Gardens. It includes free access to all facilities. Personal and non-transferable to all assignees, reviewers and testers in this issue. Valid until switching to Blackboard (100000€ penalization will be applied). Thanks, closing as fixed!

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                5 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  14/May/13