Moodle
  1. Moodle
  2. MDL-38251

Adding a top level category is named 'Add a sub-category'

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.5
    • Fix Version/s: 2.5
    • Component/s: Course
    • Labels:
    • Testing Instructions:
      Hide
      1. Log in as an admin
      2. Browse to Settings > Courses > Add/edit courses.
      3. Check there is a button that says Add new category and not add a sub category.
      4. Click on a category in the list.
      5. Check there is a button that says Add new sub category and not add new category
      Show
      Log in as an admin Browse to Settings > Courses > Add/edit courses. Check there is a button that says Add new category and not add a sub category. Click on a category in the list. Check there is a button that says Add new sub category and not add new category
    • Affected Branches:
      MOODLE_25_STABLE
    • Fixed Branches:
      MOODLE_25_STABLE
    • Pull Master Branch:
      wip-MDL-38251-m25

      Description

      When at the 'top' of the category page:
      Home ▶ Site administration ▶ Courses ▶ Add/edit courses

      The 'add a category' button is named 'Add a sub-category'. Its not a subcategory so shouldn't be named like that. You are adding a top level category

        Gliffy Diagrams

          Activity

          Hide
          Dan Poltawski added a comment -

          Sam, think this is a regression from the recent course managment refactoring.

          Show
          Dan Poltawski added a comment - Sam, think this is a regression from the recent course managment refactoring.
          Hide
          Sam Hemelryk added a comment -

          Thanks for the report Dan, should be an easy fix

          Show
          Sam Hemelryk added a comment - Thanks for the report Dan, should be an easy fix
          Hide
          Sam Hemelryk added a comment -

          Putting this up for peer-review now.

          Show
          Sam Hemelryk added a comment - Putting this up for peer-review now.
          Hide
          Dan Poltawski added a comment -

          +1, thanks Sam

          Show
          Dan Poltawski added a comment - +1, thanks Sam
          Hide
          Eloy Lafuente (stronk7) added a comment -

          The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

          TIA and ciao

          Show
          Eloy Lafuente (stronk7) added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
          Hide
          Aparup Banerjee added a comment -

          thanks, integrated into master.

          Show
          Aparup Banerjee added a comment - thanks, integrated into master.
          Hide
          Jason Fowler added a comment -

          Works perfectly.

          Show
          Jason Fowler added a comment - Works perfectly.
          Hide
          Eloy Lafuente (stronk7) added a comment -

          This is valid for unlimited entries to the, soon to be unveiled, Moodle Codebase Gardens. It includes free access to all facilities.

          Personal and non-transferable to all assignees, reviewers and testers in this issue. Valid until switching to Blackboard (100000€ penalization will be applied).

          Thanks, closing as fixed!

          Show
          Eloy Lafuente (stronk7) added a comment - This is valid for unlimited entries to the, soon to be unveiled, Moodle Codebase Gardens. It includes free access to all facilities. Personal and non-transferable to all assignees, reviewers and testers in this issue. Valid until switching to Blackboard (100000€ penalization will be applied). Thanks, closing as fixed!

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: