Hi Rosie,
The patch looks good. But am just wondering if we should be handling timezones, in here. Anyways am happy as long as we are using time() at both ends of calls.
Thanks

Hi Ankit,

Thank you for reviewing.

When an assignment is created, it doesn't handle the timezones for both timeavailable and timedue. Also the isopen() is using time() to check the assignment's status. That is why I used time() to fixed this issue.

Submitting for integration review.

The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

Thanks!

Sorry, I'm reopening this:

1) tiny invalid whitespace.
2) This condition, both in online and uploadsingle... is it correct?

} else if ($this->assignment->timeavailable < time()) {

    echo $OUTPUT->heading(get_string('closedassignment','assignment'), 3);

isn't "timeavailable" the START of the availability? If so, how can it be considered closed? IMO "timeavailable" only can be used to show the "futureaassignment" message, but not the "closedassignment" one.

Note that perhaps I'm wrong (haven't looked to every assignment type), but seems that there is a discrepancy between those 2 (online and uploadsingle) and the assignment_base implementation, that seems correct (using "timedue").

Please, verify... ciao

Moving this reopened issue out from current integration. Please, re-submit it for integration once ready.

Hi Eloy,

Thanks for the feedback.

The timedue check is done through isopen(), however the function also check for preventlate setting which is available for all types except offline.

You are right, the above condition should be greater than time for future availability. Updated the patch to fix that and whitespace.

Re-submit for integration review.

The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

TIA and ciao

Integrated to master, 24 and 23.

To me this sounded like an improvement more than a bug and relatively minor. Please can you consider closing these type of issues wont-fix, mod_assign is the future.

25,24,23 - Single Upload - There is no message when the due date is in the past.
25,24,23 - Online Text - There is no message when the due date is in the past.
25,24,23 - Offline Submission - There is no message when the due date is in the past.

Offline is also generating this: Fatal error: Call to a member function heading() on a non-object in /home/jason/www/repos/imaster/moodle/mod/assignment/lib.php on line 169

This is very disappointing.

Seems like it has not been tested?

I've reverted this and would recommend closing it wont-fix.

Hi Dan,

Sorry for the lack of testing the patch.

Just finished updating the patch.

I don't mind closing this issue, because it is an improvement for the assignment module.

I will leave patch available and close this issue.

Rosie

Moving this reopened issue out from current integration. Please, re-submit it for integration once ready.