Moodle
  1. Moodle
  2. MDL-38261

Big images attached to workshop submission displayed at their full size

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.4.1
    • Fix Version/s: 2.5
    • Component/s: Workshop
    • Testing Instructions:
      Hide

      Testing difficulty: easy

      Please test with $CFG->slasharguments enabled as well as disabled.

      1. Set up a workshop with maximum number of allowed attachments set to 7.
      2. Switch to the submission phase.
      3. Prepare your submission - attach a mix of really big images (like camera photos in their native size) and small images (like profile photos or icons)
      4. Save and see the submission
      Show
      Testing difficulty: easy Please test with $CFG->slasharguments enabled as well as disabled. Set up a workshop with maximum number of allowed attachments set to 7. Switch to the submission phase. Prepare your submission - attach a mix of really big images (like camera photos in their native size) and small images (like profile photos or icons) Save and see the submission
    • Affected Branches:
      MOODLE_24_STABLE
    • Fixed Branches:
      MOODLE_25_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-38261-workshop-attachments-size
    • Rank:
      48110

      Description

      Steps to reproduce:

      1. Set up a workshop with maximum number of allowed attachments set to 7.
      2. Switch to the submission phase.
      3. Prepare your submission - attach a mix of really big images (like camera photos in their native size) and small images (like profile photos or icons)
      4. Save and see the submission

      Expected result:

      • All attached images should be visible at reasonable preview size

      Actual result:

      • It sucks. Big images occupy the screen and it's easy to overlook smaller ones.
      1. 001-before.png
        831 kB
      2. 002-after.png
        255 kB

        Issue Links

          Activity

          Hide
          David Mudrak added a comment -

          Attaching screenshots that illustrates the problem and how it looks when fixed.

          Show
          David Mudrak added a comment - Attaching screenshots that illustrates the problem and how it looks when fixed.
          Hide
          David Mudrak added a comment -

          Submitting for integration.

          Show
          David Mudrak added a comment - Submitting for integration.
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Integrated (master only), thanks!

          Don't forget to document that new mode where necessary, TIA!

          Show
          Eloy Lafuente (stronk7) added a comment - Integrated (master only), thanks! Don't forget to document that new mode where necessary, TIA!
          Hide
          Jason Fowler added a comment -

          Thanks David, works perfectly.

          Show
          Jason Fowler added a comment - Thanks David, works perfectly.
          Hide
          Eloy Lafuente (stronk7) added a comment -

          This is valid for unlimited entries to the, soon to be unveiled, Moodle Codebase Gardens. It includes free access to all facilities.

          Personal and non-transferable to all assignees, reviewers and testers in this issue. Valid until switching to Blackboard (100000€ penalization will be applied).

          Thanks, closing as fixed!

          Show
          Eloy Lafuente (stronk7) added a comment - This is valid for unlimited entries to the, soon to be unveiled, Moodle Codebase Gardens. It includes free access to all facilities. Personal and non-transferable to all assignees, reviewers and testers in this issue. Valid until switching to Blackboard (100000€ penalization will be applied). Thanks, closing as fixed!

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: