Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-38285

Migrate moodle- YUI modules to use shifter

    XMLWordPrintable

    Details

    • Type: Task
    • Status: Open
    • Priority: Minor
    • Resolution: Unresolved
    • Affects Version/s: 2.4
    • Fix Version/s: DEV backlog
    • Component/s: JavaScript
    • Labels:
    • Testing Instructions:
      Hide

      Generic Notes

      These testing instructions should be carried out twice (once with jsrev = -1, once without) to confirm that the correct versions of JS are used and work as expected.

      Tip: Open your browser's developer toolkit, open the 'Network' activity tab, and restrict to 'Scripts'.

      Note: You may find that the script you're looking for is included with a number of other scripts - this is because of our combo loading.
      You can turn off comboloading to make it easier to check the relevant script by setting

      $CFG->yuicomboloading = false;

      , but you should check that functionality works with combo loading enabled.

      To test the minified code:

      Required settings:

      // Ensure you aren't overriding $CFG->jsrev
      $CFG->debug = 0;
      

      Notes

      Check that the minified version of this module is loaded.
      It will have -min.js in the filename but please ensure content is also be minified

      and to test the non-minified code:

      Required settings:

      $CFG->jsrev = -1;
      $CFG->debug = (E_ALL | E_STRICT);
      

      Notes

      Check that the non-minified version of this module is loaded.
      It will have -debug.js in the filename and the file content should not be minified.

      Module-specific test instructions

      Show
      Generic Notes These testing instructions should be carried out twice (once with jsrev = -1, once without) to confirm that the correct versions of JS are used and work as expected. Tip : Open your browser's developer toolkit, open the 'Network' activity tab, and restrict to 'Scripts'. Note : You may find that the script you're looking for is included with a number of other scripts - this is because of our combo loading. You can turn off comboloading to make it easier to check the relevant script by setting $CFG->yuicomboloading = false; , but you should check that functionality works with combo loading enabled. To test the minified code: Required settings: // Ensure you aren't overriding $CFG->jsrev $CFG->debug = 0; Notes Check that the minified version of this module is loaded. It will have -min.js in the filename but please ensure content is also be minified and to test the non-minified code: Required settings: $CFG->jsrev = -1; $CFG->debug = (E_ALL | E_STRICT); Notes Check that the non-minified version of this module is loaded. It will have -debug.js in the filename and the file content should not be minified. Module-specific test instructions
    • Affected Branches:
      MOODLE_24_STABLE

      Description

      Move all of our YUI modules to use shifter. We have modules currently located in:
      ./backup/util/ui/yui
      ./blocks/community/yui
      ./blocks/navigation/yui
      ./calendar/yui
      ./course/yui
      ./enrol/cohort/yui
      ./enrol/manual/yui
      ./enrol/yui
      ./filter/glossary/yui
      ./grade/grading/yui
      ./lib/editor/tinymce/yui
      ./lib/form/yui
      ./lib/yui

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              Unassigned
              Reporter:
              dobedobedoh Andrew Nicols
              Participants:
              Component watchers:
              Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated: