Moodle
  1. Moodle
  2. MDL-38298

Allow filter_emoticon to be easily reusable

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.5
    • Fix Version/s: 2.5
    • Component/s: Filters
    • Labels:
      None
    • Rank:
      48161

      Description

      While working on the filter_skypeicons filter (MDLSITE-2137), it was researched about the possibility of extending filter_emoticon to get some benefits from it.

      One immediate, trivial change is to allow all the configuration handling, to be reused, right now it cannot.

      So this is about to perform that tiny change to allow other filters to be extending filter_emoticon.

      Note this is only a little step. Surely some day we'll need better emoticon support along multiple filters... but it's a step in the correct direction for now.

      Ciao

        Activity

        Hide
        Eloy Lafuente (stronk7) added a comment -

        Sending to peer review... I think it's simple enough and covered by tests to be backported to 24_STABLE. That way the filter_skypeicons could get benefit of this immediately. FYC!

        Show
        Eloy Lafuente (stronk7) added a comment - Sending to peer review... I think it's simple enough and covered by tests to be backported to 24_STABLE. That way the filter_skypeicons could get benefit of this immediately. FYC!
        Hide
        David Mudrak added a comment -

        +1 It is a little step for a human, but a big leap for the mankind. Thanks for improving this Eloy!

        Show
        David Mudrak added a comment - +1 It is a little step for a human, but a big leap for the mankind. Thanks for improving this Eloy!
        Hide
        Sam Hemelryk added a comment -

        Thanks Eloy - has been integrated now.

        Show
        Sam Hemelryk added a comment - Thanks Eloy - has been integrated now.
        Hide
        Aparup Banerjee added a comment -

        lol@ test instructions. looks like running phpunit test is enough to test this.

        Show
        Aparup Banerjee added a comment - lol@ test instructions. looks like running phpunit test is enough to test this.
        Hide
        Rossiani Wijaya added a comment -

        Thanks Apu for commenting.

        This works as expected.

        Tested for master only.

        Test passed.

        Show
        Rossiani Wijaya added a comment - Thanks Apu for commenting. This works as expected. Tested for master only. Test passed.
        Hide
        Eloy Lafuente (stronk7) added a comment -

        Buf, apologies, somehow I missed the testing instructions and/or put the comment there instead, grrr.

        Yes, it includes specific tests to verify everything continues working ok. So passing unit tests should lead to pass the testing phase.

        Thanks!

        Show
        Eloy Lafuente (stronk7) added a comment - Buf, apologies, somehow I missed the testing instructions and/or put the comment there instead, grrr. Yes, it includes specific tests to verify everything continues working ok. So passing unit tests should lead to pass the testing phase. Thanks!
        Hide
        Eloy Lafuente (stronk7) added a comment -

        This is valid for unlimited entries to the, soon to be unveiled, Moodle Codebase Gardens. It includes free access to all facilities.

        Personal and non-transferable to all assignees, reviewers and testers in this issue. Valid until switching to Blackboard (100000€ penalization will be applied).

        Thanks, closing as fixed!

        Show
        Eloy Lafuente (stronk7) added a comment - This is valid for unlimited entries to the, soon to be unveiled, Moodle Codebase Gardens. It includes free access to all facilities. Personal and non-transferable to all assignees, reviewers and testers in this issue. Valid until switching to Blackboard (100000€ penalization will be applied). Thanks, closing as fixed!
        Hide
        Eloy Lafuente (stronk7) added a comment -

        (oh, this was not backported to 24, sniff, sniff)

        Show
        Eloy Lafuente (stronk7) added a comment - (oh, this was not backported to 24, sniff, sniff)

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: