[MDL-38300] Notice using the switch role feature - Moodle Tracker

XML

Word

Printable

Details

Type: Bug
Status: Closed
Priority: Minor
Resolution: Fixed
Affects Version/s: 2.5
Fix Version/s: 2.5
Component/s: Navigation
Labels:
- triaged

Affected Branches:
MOODLE_25_STABLE
Fixed Branches:
MOODLE_25_STABLE
Pull from Repository:
git://github.com/samhemelryk/moodle.git
Pull Master Branch:
wip-~~MDL-38300~~-m25
Pull Master Diff URL:
http://github.com/samhemelryk/moodle/commit/wip-MDL-38300-m25
Testing Instructions:
1. Log in as an admin.
2. Browse to a course.
3. Switch to a student role.
4. Check you don't get any notices.

Description

This seems to be a regression of ~~MDL-31983~~.

Under Moodle 2.5, logged as admin, go to any course and try "Switch role to student".

The switch happens but this is shown:

Notice: Undefined variable: iscurrentuser in lib/navigationlib.php on line 3965

It seems that, or the calculation of $iscurrentuser is missing in generate_user_settings() or the code is incorrectly copied/pasted or similar from load_for_user().

Ciao

Attachments

Issue Links

is a regression caused by

MDL-31983 Include Reports Under Settings block -> Course administration

Closed

Activity

People

Assignee:: Sam Hemelryk

Reporter:: Eloy Lafuente (stronk7)

Integrator:: Eloy Lafuente (stronk7)

Tester:: David Monllaó

Participants:: David Monllaó, Eloy Lafuente (stronk7), Sam Hemelryk

Component watchers:: David Woloszyn, Huong Nguyen, Jake Dallimore, Meirza, Michael Hawkins, Raquel Ortega, Safat Shahin, Stevani Andolo

Votes:: 0 Vote for this issue

Watchers:: 2 Start watching this issue

Dates

Created:: 04/Mar/13 9:04 AM

Updated:: 08/Mar/13 12:20 AM

Resolved:: 08/Mar/13 12:20 AM

Fix Release Date:: 14/May/13