[MDL-38309] Convert tab functions in weblib to a renderer - Moodle Tracker

XML

Word

Printable

Affected Branches:
MOODLE_24_STABLE, MOODLE_25_STABLE
Fixed Branches:
MOODLE_25_STABLE
Pull from Repository:
git://github.com/marinaglancy/moodle.git
Pull Main Branch:
wip-~~MDL-38309~~-m25
Pull Main Diff URL:
https://github.com/marinaglancy/moodle/compare/master...wip-MDL-38309-m25
Testing Instructions:
Hide

Check that tabs are displayed and can be navigated on pages:

Pages where usage of print_tabs() was replaced with $OUTPUT->tabtree():

/admin/roles/manage.php

Badges

Course administration->Groups

Database module

Wiki module

Also search code for non substituted usage of print_tabs(), pick any page (or two) and check that print_tabs() still works
Show
Check that tabs are displayed and can be navigated on pages: Pages where usage of print_tabs() was replaced with $OUTPUT->tabtree(): /admin/roles/manage.php Badges Course administration->Groups Database module Wiki module Also search code for non substituted usage of print_tabs(), pick any page (or two) and check that print_tabs() still works

The tab function in lib/weblib.php has a few issues with its API and the HTML that it outputs.

It would be a good first step to move this code to the core renderer class.

will help resolve

MDL-38016 Add a Moodle bootstrap theme to Moodle CORE

MDL-38924 Missing styles with multiple tab rows

MDL-31816 Wiki 'Files' tab renders tab set and page content in a manner inconsistent with other wiki tabs

MDL-32484 Wiki tabs don't display "Administration" tab from within "Files" tab

Participants:: Adrian Greeve, Dan Poltawski, David Scotson, Marina Glancy, Martin Dougiamas, Mary Evans, Petr Skoda