Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-38315

Completion: Bugs with 'locked' status in activity form

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.2.9, 2.3.3, 2.4.1
    • Fix Version/s: 2.3.7, 2.4.4
    • Component/s: Activity completion
    • Labels:
      None
    • Testing Instructions:
      Hide

      0. Enable activity completion at site level and in a test course.
      1. Create a new forum. Set completion tracking to 'when conditions are met', tick both 'require view' and 'require posts' (leaving the latter at default value 1), and save and return to course.
      2. Turn editing off.

      • Note that the forum now shows an unticked box.

      3. Start a new discussion in the forum, with any text and name.
      4. Go back to the course page.

      • Note that the forum now shows a ticked box.

      5. Edit forum settings again. This time, just change the forum name e.g. by adding '2' to the end. Hit 'save and display'.

      EXPECTED: The forum is renamed.
      BEFORE FIX: The form reloads with an error message 'When you select automatic completion, you must also enable at least one requirement (below).'

      6. Edit forum settings again. Look in the completion settings.

      EXPECTED: The 'require posts' and 'view' tickboxes, which are currently disabled because completion is locked, should nevertheless still be ticked.
      BEFORE FIX: The tickboxes are unticked - completion options were saved even though completion was not unlocked.

      THE FOLLOWING TEST STEPS NEED TO BE REPEATED FOR THESE MODULES:

      • assign (in Moodle 2.4+ only)
      • choice
      • feedback (make visible in site settings if not showing)
      • forum
      • glossary
      • scorm

      (This is to test that I didn't break the saving of custom completion rule fields when the data isn't locked.)

      7. Create an instance of the module. Enable automatic completion, and tick all the automatic completion option boxes. (In the case of forum and glossary, you must also turn on the 'Aggregate type' option under 'Ratings' as otherwise the grade completion will cause an error. For SCORM I used an example SCORM package from http://www.xquestion.com/Examples.html.) Save and display.

      8. Edit settings. Verify that all the boxes are ticked. Now untick all the boxes except 'require view', save and display.

      9. Edit settings. Verify that the boxes (except require view) are now unticked. (Note: Completion will probably now be locked because you've viewed it, but this doesn't matter as you can still tell if the boxes are ticked or not.)

      Show
      0. Enable activity completion at site level and in a test course. 1. Create a new forum. Set completion tracking to 'when conditions are met', tick both 'require view' and 'require posts' (leaving the latter at default value 1), and save and return to course. 2. Turn editing off. Note that the forum now shows an unticked box. 3. Start a new discussion in the forum, with any text and name. 4. Go back to the course page. Note that the forum now shows a ticked box. 5. Edit forum settings again. This time, just change the forum name e.g. by adding '2' to the end. Hit 'save and display'. EXPECTED: The forum is renamed. BEFORE FIX: The form reloads with an error message 'When you select automatic completion, you must also enable at least one requirement (below).' 6. Edit forum settings again. Look in the completion settings. EXPECTED: The 'require posts' and 'view' tickboxes, which are currently disabled because completion is locked, should nevertheless still be ticked. BEFORE FIX: The tickboxes are unticked - completion options were saved even though completion was not unlocked. THE FOLLOWING TEST STEPS NEED TO BE REPEATED FOR THESE MODULES: assign (in Moodle 2.4+ only) choice feedback (make visible in site settings if not showing) forum glossary scorm (This is to test that I didn't break the saving of custom completion rule fields when the data isn't locked.) 7. Create an instance of the module. Enable automatic completion, and tick all the automatic completion option boxes. (In the case of forum and glossary, you must also turn on the 'Aggregate type' option under 'Ratings' as otherwise the grade completion will cause an error. For SCORM I used an example SCORM package from http://www.xquestion.com/Examples.html .) Save and display. 8. Edit settings. Verify that all the boxes are ticked. Now untick all the boxes except 'require view', save and display. 9. Edit settings. Verify that the boxes (except require view) are now unticked. (Note: Completion will probably now be locked because you've viewed it, but this doesn't matter as you can still tell if the boxes are ticked or not.)
    • Affected Branches:
      MOODLE_22_STABLE, MOODLE_23_STABLE, MOODLE_24_STABLE
    • Fixed Branches:
      MOODLE_23_STABLE, MOODLE_24_STABLE
    • Pull Master Branch:
      MDL-38315-master

      Description

      I have duplicated this with forum, glossary and OU blog on 2.3.3+, and on demo.moodle.net using 2.4.1+. This occurs when requiring a certain number of posts. No changes can be made to any settings without removing activity completion requirements. I was not even able to change the max attachment size. It does not happen when allowing a student to manually mark an item complete or requiring a student to view to mark it complete.

      Discussion: https://moodle.org/mod/forum/discuss.php?d=223412

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

                People

                • Votes:
                  6 Vote for this issue
                  Watchers:
                  9 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:
                    Fix Release Date:
                    13/May/13