Moodle
  1. Moodle
  2. MDL-38336

Any item of the TOC is linked when "Display course structure on entry page (displaycoursestructure)" is on

    Details

    • Testing Instructions:
      Hide

      (Difficulty: easy, requires teacher access to a course)

      1. Publish the SCORM Package provided by the OP in the Community forum: https://moodle.org/pluginfile.php/137/mod_forum/attachment/970364/demo%20TOC.zip
      2. Edit settings of this new SCORM activity to match the ones from the OP:
        • Student skip content structure page: Always
        • Disable preview mode: Yes
        • Display course structure on entry page: Yes
        • Display course structure in player: Disabled
      3. Enter the SCORM activity and look at the linked items in the course structure, they should be:
        1. Toets 1, under Instaptoets
        2. A - 1, under Oefenen
      Show
      (Difficulty: easy, requires teacher access to a course) Publish the SCORM Package provided by the OP in the Community forum: https://moodle.org/pluginfile.php/137/mod_forum/attachment/970364/demo%20TOC.zip Edit settings of this new SCORM activity to match the ones from the OP: Student skip content structure page: Always Disable preview mode: Yes Display course structure on entry page: Yes Display course structure in player: Disabled Enter the SCORM activity and look at the linked items in the course structure, they should be: Toets 1 , under Instaptoets A - 1 , under Oefenen
    • Affected Branches:
      MOODLE_24_STABLE
    • Fixed Branches:
      MOODLE_24_STABLE
    • Pull from Repository:
    • Pull 2.4 Branch:
      m24_MDL-38336_SCORM_TOC_links_when_Display_course_structure_is_on
    • Pull Master Branch:
      m25_MDL-38336_SCORM_TOC_links_when_Display_course_structure_is_on
    • Rank:
      48214

      Description

      For the details see https://moodle.org/mod/forum/discuss.php?d=222525.
      Shortly, when displaycoursestructure is on, the TOC is built with each item ready to be launched regardless of actually being linked to a launchable content i.e. w/o item@identifierref being eventually defined.

        Activity

        Hide
        Matteo Scaramuccia added a comment -

        I'll think a little bit to my patch proposal than completing with the backport to 2.4 and the testing instructions.

        Show
        Matteo Scaramuccia added a comment - I'll think a little bit to my patch proposal than completing with the backport to 2.4 and the testing instructions.
        Hide
        Dan Marsden added a comment -

        thanks for the report/fix Matteo - I'll try to look at it later this week.

        Show
        Dan Marsden added a comment - thanks for the report/fix Matteo - I'll try to look at it later this week.
        Hide
        Matteo Scaramuccia added a comment -

        Hi Dan,
        here is the patch proposal: hoping it gets into 2.5 before the code freeze.

        HTH,
        Matteo

        Show
        Matteo Scaramuccia added a comment - Hi Dan, here is the patch proposal: hoping it gets into 2.5 before the code freeze. HTH, Matteo
        Hide
        Dan Marsden added a comment -

        looks good to me (FYI Freeze is for improvements/features - bug fixes are still allowed during freeze)

        Show
        Dan Marsden added a comment - looks good to me (FYI Freeze is for improvements/features - bug fixes are still allowed during freeze)
        Hide
        Damyon Wiese added a comment -

        Tested on 2.3 and the bug does not occur there.

        Show
        Damyon Wiese added a comment - Tested on 2.3 and the bug does not occur there.
        Hide
        Damyon Wiese added a comment -

        Tested on master and this does fix the reported bug.

        Thanks Matteo and Dan - integrated to 24 and master.

        Show
        Damyon Wiese added a comment - Tested on master and this does fix the reported bug. Thanks Matteo and Dan - integrated to 24 and master.
        Hide
        Matteo Scaramuccia added a comment -

        Hi Damyon,
        TNX: sorry, I've missed to tell that this bug is a regression of the TOC code rewrite in 2.4 i.e. 2.3 and below are not affected.

        Show
        Matteo Scaramuccia added a comment - Hi Damyon, TNX: sorry, I've missed to tell that this bug is a regression of the TOC code rewrite in 2.4 i.e. 2.3 and below are not affected.
        Hide
        David Monllaó added a comment -

        It passes, I see

        • Duits Niveau 1
        • Instaptoets
          • Toets 1
          • Toets 2 (without link)
          • Toets 3 (without link)
        • Oefenen
          • A - 1
          • A - 2 (without link)
          • A - 3 (without link)
          • A - 4 (without link)
          • A - 5 (without link)
          • A - 6 (without link)
        Show
        David Monllaó added a comment - It passes, I see Duits Niveau 1 Instaptoets Toets 1 Toets 2 (without link) Toets 3 (without link) Oefenen A - 1 A - 2 (without link) A - 3 (without link) A - 4 (without link) A - 5 (without link) A - 6 (without link)
        Hide
        Damyon Wiese added a comment -

        Thanks for your hard work. This issue has been integrated upstream and is now available via git (and in some hours, via mirrors and downloads).

        Show
        Damyon Wiese added a comment - Thanks for your hard work. This issue has been integrated upstream and is now available via git (and in some hours, via mirrors and downloads).

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: