Details

      Description

      When activity completion is enabled for a course, on the activities creation page, the completion settings show in an old style section below all the other sections. It looks odd!

        Gliffy Diagrams

          Issue Links

            Activity

            Hide
            quen Sam Marshall added a comment -

            That's freaky. I'm pretty sure this was working (btw the collapse 'feature' is annoying as hell, imo if it's not possible to make it display collapsed initially then the entire feature should be removed, but anyhow) last week.

            Show
            quen Sam Marshall added a comment - That's freaky. I'm pretty sure this was working (btw the collapse 'feature' is annoying as hell, imo if it's not possible to make it display collapsed initially then the entire feature should be removed, but anyhow) last week.
            Hide
            dobedobedoh Andrew Nicols added a comment -

            Adding Ruslan as a watcher.

            Show
            dobedobedoh Andrew Nicols added a comment - Adding Ruslan as a watcher.
            Hide
            dobedobedoh Andrew Nicols added a comment -

            It seems to happen to the last fieldset on any mod form. Disabling course completion causes the 'Common module settings' form to not be collapsed instead.

            Show
            dobedobedoh Andrew Nicols added a comment - It seems to happen to the last fieldset on any mod form. Disabling course completion causes the 'Common module settings' form to not be collapsed instead.
            Hide
            dobedobedoh Andrew Nicols added a comment -

            Ah - the first header is collapsible (but not collapsed) instead of the last one.

            Show
            dobedobedoh Andrew Nicols added a comment - Ah - the first header is collapsible (but not collapsed) instead of the last one.
            Hide
            dobedobedoh Andrew Nicols added a comment -

            Just having a tinker with this. I'll leave it in Sam's capable hands now but thought I'd offer what I have so far - this seems to work as I expect. I'm not sure what the purpose of working on the previous header each time is.
            There is another example where lastHeader is acted upon too so it may be worth looking at adjust that too.

            Andrew

            Show
            dobedobedoh Andrew Nicols added a comment - Just having a tinker with this. I'll leave it in Sam's capable hands now but thought I'd offer what I have so far - this seems to work as I expect. I'm not sure what the purpose of working on the previous header each time is. There is another example where lastHeader is acted upon too so it may be worth looking at adjust that too. Andrew
            Hide
            fred Frédéric Massart added a comment -

            Thanks for the patch Andrew. Unfortunately I could not use it, I think we were working on the lastHeader because any field contained in this header can determine whether it needs to be expanded or not. I have also simplified the logic so that there is no need to duplicate the code after the end of the foreach. Up for peer review for whoever wants it!

            Show
            fred Frédéric Massart added a comment - Thanks for the patch Andrew. Unfortunately I could not use it, I think we were working on the lastHeader because any field contained in this header can determine whether it needs to be expanded or not. I have also simplified the logic so that there is no need to duplicate the code after the end of the foreach. Up for peer review for whoever wants it!
            Hide
            fred Frédéric Massart added a comment -

            Rebased this on top of MDL-38345, and set as blocker.

            Show
            fred Frédéric Massart added a comment - Rebased this on top of MDL-38345 , and set as blocker.
            Hide
            phalacee Jason Fowler added a comment -

            [Y] Syntax
            [Y] Output
            [Y] Whitespace
            [Y] Language
            [-] Databases
            [Y] Testing
            [-] Security
            [-] Documentation
            [Y] Git
            [Y] Sanity check

            Show
            phalacee Jason Fowler added a comment - [Y] Syntax [Y] Output [Y] Whitespace [Y] Language [-] Databases [Y] Testing [-] Security [-] Documentation [Y] Git [Y] Sanity check
            Hide
            fred Frédéric Massart added a comment -

            Thanks Jason.

            Show
            fred Frédéric Massart added a comment - Thanks Jason.
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

            TIA and ciao

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
            Hide
            damyon Damyon Wiese added a comment -

            Thanks Fred and Andrew for hunting down this annoying bug - lets hope Fred push on shortforms cleans up most/all of the annoyances people are having.

            This patch looks correct to me (one minor nitpick is that setExpanded gets called over an over for all elements in the first section or any section after an error is found - there are no side effects from this so I have left it as is).

            Integrated to master.

            Show
            damyon Damyon Wiese added a comment - Thanks Fred and Andrew for hunting down this annoying bug - lets hope Fred push on shortforms cleans up most/all of the annoyances people are having. This patch looks correct to me (one minor nitpick is that setExpanded gets called over an over for all elements in the first section or any section after an error is found - there are no side effects from this so I have left it as is). Integrated to master.
            Hide
            fred Frédéric Massart added a comment -

            Thanks Damyon. Indeed, at that stage the method was called all the time, but I have changed that in a MDL-38455. Cheers!

            Show
            fred Frédéric Massart added a comment - Thanks Damyon. Indeed, at that stage the method was called all the time, but I have changed that in a MDL-38455 . Cheers!
            Hide
            andyjdavis Andrew Davis added a comment -

            I think this is working fine. Passing.

            Show
            andyjdavis Andrew Davis added a comment - I think this is working fine. Passing.
            Hide
            damyon Damyon Wiese added a comment -

            This issue has been integrated upstream and is now available via git (and in some hours, via mirrors and downloads).

            Thanks for your contributions!

            Show
            damyon Damyon Wiese added a comment - This issue has been integrated upstream and is now available via git (and in some hours, via mirrors and downloads). Thanks for your contributions!

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                8 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  14/May/13