Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-38367

Course drag & drop UI improvement

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.5
    • Fix Version/s: 2.5
    • Component/s: Course, Usability
    • Labels:
    • Testing Instructions:
      Hide
      1. Enable text drag & drop under Experimental settings
      2. Turn on course editing
      3. Drag some text onto a course
        1. Check a Moodle-themed dialog box appears
        2. Check the 'name' box is disabled when 'add label to course page' is selected
        3. Check the 'name' box is enabled when 'create page resource' is selected
        4. Check the 'submit' button is disabled when 'create page resource' is selected and no name entered
        5. Check the 'submit' button is enabled when a name is entered (and disabled again if the text is deleted)
        6. Check that when editing the name 'enter' submits the form and creates a page
      4. Drag some more text
        1. Check that selecting 'label' and submitting creates a label with the text
      5. Drag a file or some text (or a link)
      6. Move the mouse over the 'Add X here' text in the section
        1. Check that you can drop directly onto the 'Add X here' text and that it uploads as expected

      As always, this needs testing in Firefox, Chrome, Safari and IE10

      Show
      Enable text drag & drop under Experimental settings Turn on course editing Drag some text onto a course Check a Moodle-themed dialog box appears Check the 'name' box is disabled when 'add label to course page' is selected Check the 'name' box is enabled when 'create page resource' is selected Check the 'submit' button is disabled when 'create page resource' is selected and no name entered Check the 'submit' button is enabled when a name is entered (and disabled again if the text is deleted) Check that when editing the name 'enter' submits the form and creates a page Drag some more text Check that selecting 'label' and submitting creates a label with the text Drag a file or some text (or a link) Move the mouse over the 'Add X here' text in the section Check that you can drop directly onto the 'Add X here' text and that it uploads as expected As always, this needs testing in Firefox, Chrome, Safari and IE10
    • Affected Branches:
      MOODLE_25_STABLE
    • Fixed Branches:
      MOODLE_25_STABLE
    • Pull Master Branch:
      MDL-38367_dnd_ui_improvements

      Description

      Here are some screenshots and things that could/should be improved in regard to the Drag & Drop on a course page:

      Text DND

      • Unlike when dropping a file, there is no introductory text, perhaps "What do you want to do with this text makes sense"
      • "What do you want to call this text" does not sound very good to me, especially that so far we only have a title/name for the text added as a "Page"

      Prompt

      • The prompt window is not standard to the new moodle dialogues
        • Buttons are too big
        • Alignment is different
        • No title bar and close button
        • The colour, size and line-hight of the text is different
      • <enter> does not trigger the submit action
      • Upload button should be greyed out when no title is entered

      Course page

      • Add text/link/file(s) here is not visible when the section is really long
      • The loading icon
        • is not aligned with the text
        • is not standard to the rest of the icons
        • does not have the proper original size
      • The progress bar style does not seem to match Moodle one's
      • DND on the text Add text/link/file(s) here does not work, you have to drag any where else in the section

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

                People

                • Votes:
                  1 Vote for this issue
                  Watchers:
                  9 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:
                    Fix Release Date:
                    14/May/13