Moodle
  1. Moodle
  2. MDL-38368

Folder displayed on course page should not display "Edit" button

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.5
    • Fix Version/s: 2.5
    • Component/s: Course
    • Labels:
    • Testing Instructions:
      Hide
      1. Add 2 folders to a course
        • One displayed "Inline on a course page"
        • One displayed "On a separate page"
        • With at least one file
      2. Make sure the folder displayed on the course page does not display an 'Edit' button below the folder content
      3. Make sure the folder displayed on a separate page displays that edit button below the folder content
      Show
      Add 2 folders to a course One displayed "Inline on a course page" One displayed "On a separate page" With at least one file Make sure the folder displayed on the course page does not display an 'Edit' button below the folder content Make sure the folder displayed on a separate page displays that edit button below the folder content
    • Affected Branches:
      MOODLE_25_STABLE
    • Fixed Branches:
      MOODLE_25_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-38368-master
    • Rank:
      48260

      Description

      Now that a folder can be displayed on the course page, it outputs an "Edit" button. I find that confusing with the common actions icons. Also, it now appears when editing is off too.

      I'd go for the removal of the this button, and the associated code:

      • The page dedicated to the edition of the folder content
      • The forms associated
      • ...

        Issue Links

          Activity

          Hide
          Dan Poltawski added a comment -

          +100, as discussed in MDL-37455.

          Assigning to Marina

          Show
          Dan Poltawski added a comment - +100, as discussed in MDL-37455 . Assigning to Marina
          Hide
          Frédéric Massart added a comment -

          Assigned Marina as peer reviewer and pushing for peer review.

          Show
          Frédéric Massart added a comment - Assigned Marina as peer reviewer and pushing for peer review.
          Hide
          Marina Glancy added a comment -

          I see, you only removed it from 'inline' view mode, than it's really simple - peer review passed

          Show
          Marina Glancy added a comment - I see, you only removed it from 'inline' view mode, than it's really simple - peer review passed
          Hide
          Frédéric Massart added a comment -

          Thank you Marina!

          Show
          Frédéric Massart added a comment - Thank you Marina!
          Hide
          Damyon Wiese added a comment -

          Simple is best.

          This has been integrated to master.

          Thanks!

          Show
          Damyon Wiese added a comment - Simple is best. This has been integrated to master. Thanks!
          Hide
          Ankit Agarwal added a comment -

          Not sure why folder name is not displayed for inline folders, anyways not related to this issue.
          Passing,
          Thanks

          Show
          Ankit Agarwal added a comment - Not sure why folder name is not displayed for inline folders, anyways not related to this issue. Passing, Thanks
          Hide
          Damyon Wiese added a comment -

          This issue has been integrated upstream and is now available via git (and in some hours, via mirrors and downloads).

          Thanks for your contributions!

          Show
          Damyon Wiese added a comment - This issue has been integrated upstream and is now available via git (and in some hours, via mirrors and downloads). Thanks for your contributions!

            People

            • Votes:
              1 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: