Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-38369

Notice displayed when creating course level webdav repo

          Details

          • Testing Instructions:
            Hide
            1. Enable Flickr Public, ensure you check 'Allow users to add a repository instance into the course' and 'Allow users to add a repository instance into the user context'.
            2. Go to Home ► My profile ► Repositories ► Admin User ► Repositories
            3. Make sure you can create/edit/delete Flickr Public instances
            4. Make sure you don't see any noticed doing that
            5. Repeat in course repositories: Home ► Courses ► Miscellaneous ► COURSE ► Repositories ► Course repositories
            Show
            Enable Flickr Public, ensure you check 'Allow users to add a repository instance into the course' and 'Allow users to add a repository instance into the user context'. Go to Home ► My profile ► Repositories ► Admin User ► Repositories Make sure you can create/edit/delete Flickr Public instances Make sure you don't see any noticed doing that Repeat in course repositories: Home ► Courses ► Miscellaneous ► COURSE ► Repositories ► Course repositories
          • Affected Branches:
            MOODLE_24_STABLE
          • Fixed Branches:
            MOODLE_23_STABLE, MOODLE_24_STABLE, MOODLE_25_STABLE
          • Pull from Repository:
          • Pull Master Branch:
            MDL-38369-master
          • Pull Master Diff URL:

            Description

            Log in as teacher, go into course, under course admin select repositories and
            create a new webdav instance. after saving config the following is displayed.

            You should really redirect before you start page output
            		 
            line 719 of /lib/outputrenderers.php: call to debugging()
            		 
            line 2536 of /lib/weblib.php: call to core_renderer->redirect_message()
            		 
            line 193 of /repository/manage_instances.php: call to redirect()

              Gliffy Diagrams

                Attachments

                  Issue Links

                  blocks

                  Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-39640 Undefined property when userwatermarks is not set (editing only)

                  • Minor - Minor loss of function where workaround is possible
                  • Closed
                  Discovered while testing

                  Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-39784 Adding a flickr instance does not ensure email address is valid.

                  • Minor - Minor loss of function where workaround is possible
                  • Open

                  Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-39641 Updating a repository instance configuration requires a change of instance name.

                  • Major - Major loss of function, incorrect output
                  • Closed

                  Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-39640 Undefined property when userwatermarks is not set (editing only)

                  • Minor - Minor loss of function where workaround is possible
                  • Closed
                  is duplicated by

                  Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-39561 Redirection warning when creating personal flickr public repository

                  • Minor - Minor loss of function where workaround is possible
                  • Closed

                    Activity

                    Ascending order - Click to sort in descending order
                    Hide
                    Permalink
                    fred Frédéric Massart added a comment -

                    This patch is not the most beautiful ever provided, but in order to come up with a more distinguished solution I'd have to rewrite the whole page, and I'm not keen on doing that just yet. Cheers!

                    Show
                    fred Frédéric Massart added a comment - This patch is not the most beautiful ever provided, but in order to come up with a more distinguished solution I'd have to rewrite the whole page, and I'm not keen on doing that just yet. Cheers!
                    Hide
                    Permalink
                    abgreeve Adrian Greeve added a comment -

                    Hello Fred,

                    I can see what you mean about re-writing the file to provide a more distinguished solution.
                    I think that this patch is okay. I can't think of a better configuration.
                    I found a couple of bugs while running through and testing the code. I created issues and linked them.

                    Show
                    abgreeve Adrian Greeve added a comment - Hello Fred, I can see what you mean about re-writing the file to provide a more distinguished solution. I think that this patch is okay. I can't think of a better configuration. I found a couple of bugs while running through and testing the code. I created issues and linked them.
                    Hide
                    Permalink
                    fred Frédéric Massart added a comment -

                    orz!

                    Show
                    fred Frédéric Massart added a comment - orz!
                    Hide
                    Permalink
                    poltawski Dan Poltawski added a comment -

                    I think the word you were looking for was 'elegant'

                    Show
                    poltawski Dan Poltawski added a comment - I think the word you were looking for was 'elegant'
                    Hide
                    Permalink
                    poltawski Dan Poltawski added a comment -

                    Integrated to masteer, 25, 24 and 23. Thanks Fred

                    Show
                    poltawski Dan Poltawski added a comment - Integrated to masteer, 25, 24 and 23. Thanks Fred
                    Hide
                    Permalink
                    poltawski Dan Poltawski added a comment -

                    And well done on the pragmatism, its how we make good products to sometimes take that decision

                    Show
                    poltawski Dan Poltawski added a comment - And well done on the pragmatism, its how we make good products to sometimes take that decision
                    Hide
                    Permalink
                    markn Mark Nelson added a comment -

                    Works as expected, passing. I found one issue unrelated to this fix and linked it.

                    Show
                    markn Mark Nelson added a comment - Works as expected, passing. I found one issue unrelated to this fix and linked it.
                    Hide
                    Permalink
                    damyon Damyon Wiese added a comment -

                    Thanks for your contribution! This issue has been reviewed, integrated, tested and now released to everyone.

                    Closing as Fixed!

                    Show
                    damyon Damyon Wiese added a comment - Thanks for your contribution! This issue has been reviewed, integrated, tested and now released to everyone. Closing as Fixed!

                      People

                      • Votes:
                        0 Vote for this issue
                        Watchers:
                        6 Start watching this issue

                        Dates

                        • Created:
                          Updated:
                          Resolved:
                          Fix Release Date:
                          8/Jul/13