Moodle
  1. Moodle
  2. MDL-38370

Strict standards errors for scorm packages

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.3.6, 2.4.1, 2.5
    • Fix Version/s: 2.3.7, 2.4.4
    • Component/s: Reports, SCORM
    • Labels:
    • Testing Instructions:
      Hide
      1. Create a course with multiple scorm activites with a few students and attempts
      2. As admin goto report/outline/user.php?id=3&course=2&mode=complete
        where id is user id of a student.
      3. Make sure you don’t see errors as seen the attached pic
      Show
      Create a course with multiple scorm activites with a few students and attempts As admin goto report/outline/user.php?id=3&course=2&mode=complete where id is user id of a student. Make sure you don’t see errors as seen the attached pic
    • Affected Branches:
      MOODLE_23_STABLE, MOODLE_24_STABLE, MOODLE_25_STABLE
    • Fixed Branches:
      MOODLE_23_STABLE, MOODLE_24_STABLE
    • Pull Master Branch:
      MDL-38370-master

      Description

      1. Create a course with multiple scorm activites with a few students and attempts
      2. As admin goto report/outline/user.php?id=3&course=2&mode=complete
        where id is user id of a student.
      3. Make sure you dont see errors as seen the attached pic

        Gliffy Diagrams

          Activity

          Hide
          Rossiani Wijaya added a comment -

          Hi Ankit,

          This looks great. Feel free to submit for integration review.

          [y] Syntax
          [-] Output
          [y] Whitespace
          [-] Language
          [-] Databases
          [y] Testing
          [-] Security
          [-] Documentation
          [y] Git
          [y] Sanity check

          Show
          Rossiani Wijaya added a comment - Hi Ankit, This looks great. Feel free to submit for integration review. [y] Syntax [-] Output [y] Whitespace [-] Language [-] Databases [y] Testing [-] Security [-] Documentation [y] Git [y] Sanity check
          Hide
          Ankit Agarwal added a comment -

          Thanks for the review Rosie.
          Submitting for integration.

          Show
          Ankit Agarwal added a comment - Thanks for the review Rosie. Submitting for integration.
          Hide
          Eloy Lafuente (stronk7) added a comment -

          The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

          TIA and ciao

          Show
          Eloy Lafuente (stronk7) added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Integrated (23, 24 & master), thanks!

          Show
          Eloy Lafuente (stronk7) added a comment - Integrated (23, 24 & master), thanks!
          Hide
          Frédéric Massart added a comment -

          Passing, thanks!

          Show
          Frédéric Massart added a comment - Passing, thanks!
          Hide
          Damyon Wiese added a comment -

          This issue has been integrated upstream and is now available via git (and in some hours, via mirrors and downloads).

          Thanks for your contributions!

          Show
          Damyon Wiese added a comment - This issue has been integrated upstream and is now available via git (and in some hours, via mirrors and downloads). Thanks for your contributions!

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: