Moodle

Fix CSS errors in Magazine theme

Details

Description

.dir-rtl.jsenabled .course_category_tree .category.with_children.collapsed .category_label

{ backkground-position: right center !important; }

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Mary Evans added a comment -

@Nadav: Just added you here as watcher as this may be affecting the view of this from the RTL commuinity. I'll be fixing this this evening.

Show
Mary Evans added a comment - @Nadav: Just added you here as watcher as this may be affecting the view of this from the RTL commuinity. I'll be fixing this this evening.
Hide
Permalink
Nadav Kavalerchik added a comment -

Thanks

Show
Nadav Kavalerchik added a comment - Thanks
Hide
Permalink
Eloy Lafuente (stronk7) added a comment -

The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

TIA and ciao

Show
Eloy Lafuente (stronk7) added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
Hide
Permalink
Mary Evans added a comment -

REBASED ALL BRANCHES:

Show
Mary Evans added a comment - REBASED ALL BRANCHES:
Hide
Permalink
Mary Evans added a comment -

Updated and tried to rebase and ended up with conflicts. So rebuilt merged/squashed and hopefully got back on track.

Show
Mary Evans added a comment - Updated and tried to rebase and ended up with conflicts. So rebuilt merged/squashed and hopefully got back on track.
Hide
Permalink
Eloy Lafuente (stronk7) added a comment -

I'm sorry but this needs some testing instructions, at least pointing to places where changes have been done.

For all branches, it's the "kk" fix, but in master there are a bunch of changes involving !important. It should be verified (tested) that they are really not needed.

Finally, please, don't mix fixes with code cleanup. It does things really hard to review. Create one "cleanup" issue and perform ONLY cleanup changes on it.

Ciao

Show
Eloy Lafuente (stronk7) added a comment - I'm sorry but this needs some testing instructions, at least pointing to places where changes have been done. For all branches, it's the "kk" fix, but in master there are a bunch of changes involving !important. It should be verified (tested) that they are really not needed. Finally, please, don't mix fixes with code cleanup. It does things really hard to review. Create one "cleanup" issue and perform ONLY cleanup changes on it. Ciao
Hide
Permalink
CiBoT added a comment -

Moving this reopened issue out from current integration. Please, re-submit it for integration once ready.

Show
CiBoT added a comment - Moving this reopened issue out from current integration. Please, re-submit it for integration once ready.
Hide
Permalink
Damyon Wiese added a comment -

The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

Thanks!

Show
Damyon Wiese added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. Thanks!
Hide
Permalink
Mary Evans added a comment -

Oh...forgot to say this has been rebased.

Show
Mary Evans added a comment - Oh...forgot to say this has been rebased.
Hide
Permalink
Damyon Wiese added a comment -

Thanks Mary,

This has been integrated to 23, 24 and master.

Show
Damyon Wiese added a comment - Thanks Mary, This has been integrated to 23, 24 and master.
Hide
Permalink
David Monllaó added a comment -

It passes, all according to the screenshot.

I've only noticed the RTL expand icon style is different from collapse icon style and LTR expand icon style.

Show
David Monllaó added a comment - It passes, all according to the screenshot. I've only noticed the RTL expand icon style is different from collapse icon style and LTR expand icon style.
Hide
Permalink
Mary Evans added a comment -

Oh it is isn't it! In that case I better fix that too. Thanks David.

Show
Mary Evans added a comment - Oh it is isn't it! In that case I better fix that too. Thanks David.
Hide
Permalink
Damyon Wiese added a comment -

Thanks for your hard work. This issue has been integrated upstream and is now available via git (and in some hours, via mirrors and downloads).

Show
Damyon Wiese added a comment - Thanks for your hard work. This issue has been integrated upstream and is now available via git (and in some hours, via mirrors and downloads).

People

Vote (0)
Watch (4)

Dates

  • Created:
    Updated:
    Resolved: