Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-38382

Update seems to truncate minor revisions

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Trivial Trivial
    • 2.5
    • 2.3.4, 2.4.1, 2.5
    • Administration
    • MOODLE_23_STABLE, MOODLE_24_STABLE, MOODLE_25_STABLE
    • MOODLE_25_STABLE
    • wip-mdl-38382
    • Hide
      1. Change micro increment of site version number (in version.php) to .10 (eg: 2013022800.00 to 2013022800.10)
      2. log in as admin and you should see upgrade page
      3. Make sure leading zero's are visible in header string and notification string. Something like

        Upgrading Moodle database from version 2.5dev (Build: 20130228) (2013022800.00) to 2.5dev (Build: 20130228) (2013022800.10)
        

      Show
      Change micro increment of site version number (in version.php) to .10 (eg: 2013022800.00 to 2013022800.10) log in as admin and you should see upgrade page Make sure leading zero's are visible in header string and notification string. Something like Upgrading Moodle database from version 2.5dev (Build: 20130228) (2013022800.00) to 2.5dev (Build: 20130228) (2013022800.10)

      Whilst testing MDL-38378 I cherry picked version version 2.3.4+ (Build: 20130228) (2012062504.10) to test the changes I made within '/lib/db/update.php' as the script has the condition:

      if ($oldversion < 2012062504.11 && $oldversion >= 2012062504.08) {
      

      So I thought a test value of 2012062504.10 would satisfy this criteria. However, the value after the decimal point appears to be truncated to 2012062504.1. And Moodle reports:

      Upgrading Moodle database from version 2.3.4+ (Build: 20130228) (2012062504.1) to 2.3.4+ (Build: 20130307) (2012062504.12)

      Note the disparity between the build date and reported Moodle version when compared with the original version.php file. Thus causing confusion on the part of the administrator / developer when using the value.

            rajeshtaneja Rajesh Taneja
            gb2048 Gareth J Barnard
            Petr Skoda Petr Skoda
            Eloy Lafuente (stronk7) Eloy Lafuente (stronk7)
            Frédéric Massart Frédéric Massart
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved:

                Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.