Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-38382

Update seems to truncate minor revisions

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: 2.3.4, 2.4.1, 2.5
    • Fix Version/s: 2.5
    • Component/s: Administration
    • Labels:
    • Testing Instructions:
      Hide
      1. Change micro increment of site version number (in version.php) to .10 (eg: 2013022800.00 to 2013022800.10)
      2. log in as admin and you should see upgrade page
      3. Make sure leading zero's are visible in header string and notification string. Something like 

        Upgrading Moodle database from version 2.5dev (Build: 20130228) (2013022800.00) to 2.5dev (Build: 20130228) (2013022800.10)

      Show
      Change micro increment of site version number (in version.php) to .10 (eg: 2013022800.00 to 2013022800.10) log in as admin and you should see upgrade page Make sure leading zero's are visible in header string and notification string. Something like Upgrading Moodle database from version 2.5dev (Build: 20130228) (2013022800.00) to 2.5dev (Build: 20130228) (2013022800.10)
    • Affected Branches:
      MOODLE_23_STABLE, MOODLE_24_STABLE, MOODLE_25_STABLE
    • Fixed Branches:
      MOODLE_25_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      wip-mdl-38382
    • Pull Master Diff URL:

      Description

      Whilst testing MDL-38378 I cherry picked version version 2.3.4+ (Build: 20130228) (2012062504.10) to test the changes I made within '/lib/db/update.php' as the script has the condition:

      if ($oldversion < 2012062504.11 && $oldversion >= 2012062504.08) {

      So I thought a test value of 2012062504.10 would satisfy this criteria. However, the value after the decimal point appears to be truncated to 2012062504.1. And Moodle reports:

      Upgrading Moodle database from version 2.3.4+ (Build: 20130228) (2012062504.1) to 2.3.4+ (Build: 20130307) (2012062504.12)

      Note the disparity between the build date and reported Moodle version when compared with the original version.php file. Thus causing confusion on the part of the administrator / developer when using the value.

        Attachments

          Issue Links

          Testing discovered

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-38378 DB Upgrade script contains hard coded database prefix.

          • Blocker - Blocks development and/or testing, prevents Moodle from running (applicable to bugs only)
          • Closed

            Activity

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  14/May/13