Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-38284 META: Improve core JavaScript processes, etc
  3. MDL-38391

Collect meta-data for YUI_config

    XMLWordPrintable

Details

    • Sub-task
    • Status: Closed
    • Critical
    • Resolution: Fixed
    • 2.5
    • 2.5
    • JavaScript, Libraries
    • MOODLE_25_STABLE
    • MOODLE_25_STABLE
    • Hide

      Apply the top commit from git://github.com/andrewnicols/moodle.git MDL-38391-testing (https://github.com/andrewnicols/moodle/commits/MDL-38391-testing)

      This adds some testing data with some sample good and bad modules.

      Open your browser JS tools - you'll need this.
      With the Network tab, you probably only want to view scripts.

      Whilst logged out:

      • open the login page

      When:

      unset($CFG->jsrev);

      confirm that the JS load for tooltip.js was comboloaded with a few other modules
      (I see 6 JS requests)

      Open the JS console and type:

      YUI_config.groups.moodle.modules

      You should get an array with various modules defined. On current integration/master I get 5:

      • moodle-core-38391good
      • moodle-core-tooltip
      • moodle-form-38391good
      • moodle-question-38391good
      • moodle-mod_assign-38391good

      These are modules from:

      • core
      • a core subsystem in a subdirectory
      • a core subsystem in a top-level directory
      • a plugin (module)

      You shouldn't see any with the name bad in them.

      When

      $CFG->jsrev = -1;

      confirm that the JS load for tooltip.js was /not/ comboloaded
      (I see 7 JS requests)

      Open the JS console and type:

      YUI_config.groups.moodle.modules

      An empty array should be returned []

      Show
      Apply the top commit from git://github.com/andrewnicols/moodle.git MDL-38391 -testing ( https://github.com/andrewnicols/moodle/commits/MDL-38391-testing ) This adds some testing data with some sample good and bad modules. Open your browser JS tools - you'll need this. With the Network tab, you probably only want to view scripts. Whilst logged out: open the login page When: unset($CFG->jsrev); confirm that the JS load for tooltip.js was comboloaded with a few other modules (I see 6 JS requests) Open the JS console and type: YUI_config.groups.moodle.modules You should get an array with various modules defined. On current integration/master I get 5: moodle-core-38391good moodle-core-tooltip moodle-form-38391good moodle-question-38391good moodle-mod_assign-38391good These are modules from: core a core subsystem in a subdirectory a core subsystem in a top-level directory a plugin (module) You shouldn't see any with the name bad in them. When $CFG->jsrev = -1; confirm that the JS load for tooltip.js was /not/ comboloaded (I see 7 JS requests) Open the JS console and type: YUI_config.groups.moodle.modules An empty array should be returned []

    Description

      Now that shifter (MDL-37127) has landed, we need to look at writing a task for cron to trawl through all of the yui/src directories, pick up meta files, and compile those into a single json structure which can be passed to YUI_config['groups']['moodle']['modules']

      This should inform the loader of dependency and improve our combo loading massively.

      Attachments

        Issue Links

          blocks

          Sub-task - Issues are sometimes broken into multiple sub-tasks. MDL-38507 YUI_config set up after SimpleYUI

          • Minor - Minor loss of function where workaround is possible
          • Closed

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-36334 Add support for selected gallery modules

          • Major - Major loss of function, incorrect output
          • Closed

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-38515 Undefined offset in yui_combo.php

          • Major - Major loss of function, incorrect output
          • Closed
          is blocked by

          Sub-task - Issues are sometimes broken into multiple sub-tasks. MDL-36198 Deprecated versions of YUI CSS libraries currently in use

          • Minor - Minor loss of function where workaround is possible
          • Closed
          will help resolve

          Sub-task - Issues are sometimes broken into multiple sub-tasks. MDL-38221 Allow specification of YUI group configuration

          • Minor - Minor loss of function where workaround is possible
          • Closed

          Activity

            People

              dobedobedoh Andrew Lyons
              dobedobedoh Andrew Lyons
              Petr Skoda Petr Skoda
              Eloy Lafuente (stronk7) Eloy Lafuente (stronk7)
              Rajesh Taneja Rajesh Taneja
              David Woloszyn, Huong Nguyen, Jake Dallimore, Meirza, Michael Hawkins, Raquel Ortega, Safat Shahin, Stevani Andolo, David Woloszyn, Huong Nguyen, Jake Dallimore, Meirza, Michael Hawkins, Raquel Ortega, Safat Shahin, Stevani Andolo
              Votes:
              1 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:
                14/May/13