Details

    • Type: Sub-task
    • Status: Closed
    • Priority: Critical
    • Resolution: Fixed
    • Affects Version/s: 2.5
    • Fix Version/s: 2.5
    • Component/s: JavaScript, Libraries
    • Labels:
    • Testing Instructions:
      Hide

      Apply the top commit from git://github.com/andrewnicols/moodle.git MDL-38391-testing (https://github.com/andrewnicols/moodle/commits/MDL-38391-testing)

      This adds some testing data with some sample good and bad modules.

      Open your browser JS tools - you'll need this.
      With the Network tab, you probably only want to view scripts.

      Whilst logged out:

      • open the login page

      When:

      unset($CFG->jsrev);
      

      confirm that the JS load for tooltip.js was comboloaded with a few other modules
      (I see 6 JS requests)

      Open the JS console and type:

      YUI_config.groups.moodle.modules
      

      You should get an array with various modules defined. On current integration/master I get 5:

      • moodle-core-38391good
      • moodle-core-tooltip
      • moodle-form-38391good
      • moodle-question-38391good
      • moodle-mod_assign-38391good

      These are modules from:

      • core
      • a core subsystem in a subdirectory
      • a core subsystem in a top-level directory
      • a plugin (module)

      You shouldn't see any with the name bad in them.

      When

      $CFG->jsrev = -1;
      

      confirm that the JS load for tooltip.js was /not/ comboloaded
      (I see 7 JS requests)

      Open the JS console and type:

      YUI_config.groups.moodle.modules
      

      An empty array should be returned []

      Show
      Apply the top commit from git://github.com/andrewnicols/moodle.git MDL-38391 -testing ( https://github.com/andrewnicols/moodle/commits/MDL-38391-testing ) This adds some testing data with some sample good and bad modules. Open your browser JS tools - you'll need this. With the Network tab, you probably only want to view scripts. Whilst logged out: open the login page When: unset($CFG->jsrev); confirm that the JS load for tooltip.js was comboloaded with a few other modules (I see 6 JS requests) Open the JS console and type: YUI_config.groups.moodle.modules You should get an array with various modules defined. On current integration/master I get 5: moodle-core-38391good moodle-core-tooltip moodle-form-38391good moodle-question-38391good moodle-mod_assign-38391good These are modules from: core a core subsystem in a subdirectory a core subsystem in a top-level directory a plugin (module) You shouldn't see any with the name bad in them. When $CFG->jsrev = -1; confirm that the JS load for tooltip.js was /not/ comboloaded (I see 7 JS requests) Open the JS console and type: YUI_config.groups.moodle.modules An empty array should be returned []
    • Affected Branches:
      MOODLE_25_STABLE
    • Fixed Branches:
      MOODLE_25_STABLE
    • Pull Master Branch:

      Description

      Now that shifter (MDL-37127) has landed, we need to look at writing a task for cron to trawl through all of the yui/src directories, pick up meta files, and compile those into a single json structure which can be passed to YUI_config['groups']['moodle']['modules']

      This should inform the loader of dependency and improve our combo loading massively.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                dobedobedoh Andrew Nicols
                Reporter:
                dobedobedoh Andrew Nicols
                Peer reviewer:
                Petr Skoda
                Integrator:
                Eloy Lafuente (stronk7)
                Tester:
                Rajesh Taneja
                Participants:
                Component watchers:
                Jake Dallimore, Jun Pataleta, Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Sara Arjona (@sarjona), Víctor Déniz Falcón
              • Votes:
                1 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  14/May/13