Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-36320 META: Move HTML generation from course/lib.php to renderer
  3. MDL-38406

Separate categories view and edit page - alter CSS

          Details

          • Type: Sub-task
          • Status: Closed
          • Priority: Minor
          • Resolution: Fixed
          • Affects Version/s: 2.4.2
          • Fix Version/s: 2.5, DEV backlog
          • Component/s: Course
          • Labels:
          • Testing Instructions:
            Hide

            While testing please not that manage.php page is going to be changed very soon anyway so throughout testing is not necessary.

            1. create couple of course and categories
            2. make sure that page /course/manage.php looks similar to course management pages in 2.4 (/course/index.php and /course/category.php in editing mode)
            3. test in mymobile theme as well
            Show
            While testing please not that manage.php page is going to be changed very soon anyway so throughout testing is not necessary. create couple of course and categories make sure that page /course/manage.php looks similar to course management pages in 2.4 (/course/index.php and /course/category.php in editing mode) test in mymobile theme as well
          • Affected Branches:
            MOODLE_24_STABLE
          • Fixed Branches:
            MOODLE_25_STABLE
          • Pull from Repository:
          • Pull Master Branch:
            wip-MDL-38406-master
          • Pull Master Diff URL:

            Description

            During the work on MDL-37572 I forgot to make changes to CSS. They refer to particular page addresses which has changed

              Gliffy Diagrams

                Attachments

                  Issue Links

                  is a regression caused by

                  Sub-task - Issues are sometimes broken into multiple sub-tasks. MDL-37572 Separate categories view and edit pages

                  • Minor - Minor loss of function where workaround is possible
                  • Closed

                    Activity

                    Ascending order - Click to sort in descending order
                    Hide
                    Permalink
                    marina Marina Glancy added a comment -

                    Hi Sam, please look at this issue, this is something I forgot about while moving editing code to /course/manage.php

                    Show
                    marina Marina Glancy added a comment - Hi Sam, please look at this issue, this is something I forgot about while moving editing code to /course/manage.php
                    Hide
                    Permalink
                    damyon Damyon Wiese added a comment -

                    Hi Marina,

                    Can you please remove the css changes for the performance report page and submit them in a separate issue? It is much better for the git history.

                    Thanks, Damyon

                    Show
                    damyon Damyon Wiese added a comment - Hi Marina, Can you please remove the css changes for the performance report page and submit them in a separate issue? It is much better for the git history. Thanks, Damyon
                    Hide
                    Permalink
                    marina Marina Glancy added a comment -

                    Hi Damyon. I did not do any changes for the performace report page or did I?

                    Show
                    marina Marina Glancy added a comment - Hi Damyon. I did not do any changes for the performace report page or did I?
                    Hide
                    Permalink
                    damyon Damyon Wiese added a comment -

                    Sorry - my bad - it was showing up in the merge commit - will integrate now.

                    Thanks!

                    Show
                    damyon Damyon Wiese added a comment - Sorry - my bad - it was showing up in the merge commit - will integrate now. Thanks!
                    Hide
                    Permalink
                    damyon Damyon Wiese added a comment -

                    Thanks Marina,

                    This has been integrated to master - sorry for the confusion.

                    Show
                    damyon Damyon Wiese added a comment - Thanks Marina, This has been integrated to master - sorry for the confusion.
                    Hide
                    Permalink
                    ankit_frenz Ankit Agarwal added a comment -

                    The controls for sub categories are intended, which is wrong imo. Attached a pic. Please suggest to pass/fail .
                    Thanks

                    Show
                    ankit_frenz Ankit Agarwal added a comment - The controls for sub categories are intended, which is wrong imo. Attached a pic. Please suggest to pass/fail . Thanks
                    Hide
                    Permalink
                    ankit_frenz Ankit Agarwal added a comment -

                    The arrows in mymobile theme appear too thin to me on the course manage page.Attached screen.

                    Show
                    ankit_frenz Ankit Agarwal added a comment - The arrows in mymobile theme appear too thin to me on the course manage page.Attached screen.
                    Hide
                    Permalink
                    marina Marina Glancy added a comment -

                    found it, it was changed in MDL-36554
                    https://github.com/marinaglancy/moodle/commit/6fc61f2d0840aba9542392038c73a293f8ed8eb9#L7R324
                    Rossie accidentally applied class 'centeralign' to this column. It's not connected to this issue I think you can pass it. Besides does not make much sense to make this page pretty now, Sam is refactoring it completely anyway

                    Show
                    marina Marina Glancy added a comment - found it, it was changed in MDL-36554 https://github.com/marinaglancy/moodle/commit/6fc61f2d0840aba9542392038c73a293f8ed8eb9#L7R324 Rossie accidentally applied class 'centeralign' to this column. It's not connected to this issue I think you can pass it. Besides does not make much sense to make this page pretty now, Sam is refactoring it completely anyway
                    Hide
                    Permalink
                    ankit_frenz Ankit Agarwal added a comment -

                    Passing as suggested.
                    Thanks

                    Show
                    ankit_frenz Ankit Agarwal added a comment - Passing as suggested. Thanks
                    Hide
                    Permalink
                    stronk7 Eloy Lafuente (stronk7) added a comment -

                    This issue has been integrated upstream and is now available both via git and cvs (and in some hours, via mirrors and downloads).

                    Thanks!

                    PS: Yay, legacy template messages. Yes, you're ok, we don't have CVS anymore!

                    Show
                    stronk7 Eloy Lafuente (stronk7) added a comment - This issue has been integrated upstream and is now available both via git and cvs (and in some hours, via mirrors and downloads). Thanks! PS: Yay, legacy template messages. Yes, you're ok, we don't have CVS anymore!

                      People

                      • Votes:
                        0 Vote for this issue
                        Watchers:
                        4 Start watching this issue

                        Dates

                        • Created:
                          Updated:
                          Resolved:
                          Fix Release Date:
                          14/May/13