Moodle
  1. Moodle
  2. MDL-38412

Quiz results report doesn't act if another page changed group

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.3.6, 2.4.1, 2.5
    • Fix Version/s: 2.3.7, 2.4.4
    • Component/s: Quiz
    • Labels:
    • Testing Instructions:
      Hide

      1. To test this, you need a course with at least two groups, and a quiz with group mode turned on that has been attempted by students from each group.

      2. In the quiz, open the Grades report in one browser tab, and switch it to one group (Group A, say).

      3. Now open another tab, go to the quiz Responses report, and select the other group (Group B, say).

      4. In the Grades report tab, try deleting the attempt. Ensure the report continues to show Group A, and the attempt is deleted.

      5. Go to the responses report tab, and Sort the table on one column. Check that it stays showing group B.

      6. If you can be bothered, check all the other actions in the two reports.

      Show
      1. To test this, you need a course with at least two groups, and a quiz with group mode turned on that has been attempted by students from each group. 2. In the quiz, open the Grades report in one browser tab, and switch it to one group (Group A, say). 3. Now open another tab, go to the quiz Responses report, and select the other group (Group B, say). 4. In the Grades report tab, try deleting the attempt. Ensure the report continues to show Group A, and the attempt is deleted. 5. Go to the responses report tab, and Sort the table on one column. Check that it stays showing group B. 6. If you can be bothered, check all the other actions in the two reports.
    • Affected Branches:
      MOODLE_23_STABLE, MOODLE_24_STABLE, MOODLE_25_STABLE
    • Fixed Branches:
      MOODLE_23_STABLE, MOODLE_24_STABLE
    • Pull from Repository:
    • Pull 2.4 Branch:
    • Pull Master Branch:
    • Rank:
      48341

      Description

      1. Get a quiz with several attempts from 2 different groups in a course, as a teacher go to the attempts link and select one group.
      2. Open in another tab results of this quiz and change group to be second one
      3. In first tab select an attempts to delete and delete it.
      4. Get back to the first group. The attempt isn't deleted.

      I know that relates to not very nice handling of group selection control, but not doing what user specified silently is still a bug.

        Activity

        Hide
        Tim Hunt added a comment -

        I think this is the best way to fix it: Add a group=X parameter to most of the action URLs when the quiz uses group mode, to ensure that the action like delete attempt or sort table keeps the currently selected group.

        Oleg, does this look like a sensible approach to you?

        Show
        Tim Hunt added a comment - I think this is the best way to fix it: Add a group=X parameter to most of the action URLs when the quiz uses group mode, to ensure that the action like delete attempt or sort table keeps the currently selected group. Oleg, does this look like a sensible approach to you?
        Hide
        Oleg Sychev added a comment -

        Hi, Tim.

        This look like a sensible approach if there is no sensible way to get value of group combo box directly from the submitted page, instead of Moodle tinkering with it.

        Show
        Oleg Sychev added a comment - Hi, Tim. This look like a sensible approach if there is no sensible way to get value of group combo box directly from the submitted page, instead of Moodle tinkering with it.
        Hide
        Tim Hunt added a comment -

        You could say that what I have done is to ensure that the submitted page gets the right value for the groups drop-down.

        Thanks for looking at it. Submitting for integration.

        Show
        Tim Hunt added a comment - You could say that what I have done is to ensure that the submitted page gets the right value for the groups drop-down. Thanks for looking at it. Submitting for integration.
        Hide
        Eloy Lafuente (stronk7) added a comment -

        Integrated (23, 24 & master), thanks!

        Show
        Eloy Lafuente (stronk7) added a comment - Integrated (23, 24 & master), thanks!
        Hide
        Andrew Davis added a comment -

        Works as described. Passing.

        Show
        Andrew Davis added a comment - Works as described. Passing.
        Hide
        Damyon Wiese added a comment -

        This issue has been integrated upstream and is now available via git (and in some hours, via mirrors and downloads).

        Thanks for your contributions!

        Show
        Damyon Wiese added a comment - This issue has been integrated upstream and is now available via git (and in some hours, via mirrors and downloads). Thanks for your contributions!

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: