Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.5
    • Fix Version/s: 2.5
    • Component/s: Forms Library
    • Labels:
    • Rank:
      48342

      Description

      1) Make it collapsible
      2) Get rid of advanced (Show more)

        Activity

        Hide
        Frédéric Massart added a comment -

        Here is a patch to solve the 2nd problem (the first one being solved in MDL-38340). But at 2nd though I am not sure this should be fixed at all. The current logic sets the roles which cannot be assigned as advanced. I think this makes sense not to pollute the interface with useless options.

        Anyway, pushing for peer review.

        Show
        Frédéric Massart added a comment - Here is a patch to solve the 2nd problem (the first one being solved in MDL-38340 ). But at 2nd though I am not sure this should be fixed at all. The current logic sets the roles which cannot be assigned as advanced . I think this makes sense not to pollute the interface with useless options. Anyway, pushing for peer review.
        Hide
        Rajesh Taneja added a comment -

        Thanks Fred,

        Patch looks spot-on.

        [y] Syntax
        [y] Output
        [y] Whitespace
        [-] Language
        [-] Databases
        [y] Testing
        [-] Security
        [-] Documentation
        [y] Git
        [y] Sanity check

        Show
        Rajesh Taneja added a comment - Thanks Fred, Patch looks spot-on. [y] Syntax [y] Output [y] Whitespace [-] Language [-] Databases [y] Testing [-] Security [-] Documentation [y] Git [y] Sanity check
        Hide
        Frédéric Massart added a comment -

        Raj orz!

        Show
        Frédéric Massart added a comment - Raj orz!
        Hide
        Eloy Lafuente (stronk7) added a comment -

        The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

        TIA and ciao

        Show
        Eloy Lafuente (stronk7) added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
        Hide
        Eloy Lafuente (stronk7) added a comment -

        Integrated (master only), thanks!

        Show
        Eloy Lafuente (stronk7) added a comment - Integrated (master only), thanks!
        Hide
        Adrian Greeve added a comment -

        Tested on the master integration branch.
        No 'show more' was displayed.
        Test passed. \o/

        Show
        Adrian Greeve added a comment - Tested on the master integration branch. No 'show more' was displayed. Test passed. \o/
        Hide
        Frédéric Massart added a comment -

        I am not sure we should have fixed this at all.

        Show
        Frédéric Massart added a comment - I am not sure we should have fixed this at all.
        Hide
        Martin Dougiamas added a comment -

        Originally I thought the overall simplification in the Moodle GUI outweighed the slightly longer list of names.

        But I am slightly concerned thinking now about sites that may have a lot of wierd roles set up for different things ...

        Guess we can wait for those complaints, if any.

        Show
        Martin Dougiamas added a comment - Originally I thought the overall simplification in the Moodle GUI outweighed the slightly longer list of names. But I am slightly concerned thinking now about sites that may have a lot of wierd roles set up for different things ... Guess we can wait for those complaints, if any.
        Hide
        Eloy Lafuente (stronk7) added a comment -

        so?

        Show
        Eloy Lafuente (stronk7) added a comment - so?
        Hide
        Frédéric Massart added a comment -

        In MDL-38415 Helen is suggesting that we move 'Role renaming' into another category, do you think this would be too much if some are not set as advanced?

        Show
        Frédéric Massart added a comment - In MDL-38415 Helen is suggesting that we move 'Role renaming' into another category, do you think this would be too much if some are not set as advanced?
        Hide
        David Monllaó added a comment -

        The edit course page is currently used to test the "expand all form's fieldsets and advanced elements" step and is breaking the behat tests as it doesn't contain any other advanced fields and 'Show less...' can not be found. Adding a patch on top of integration changing from edit course form to forum form.

        repo: git://github.com/dmonllao/moodle.git
        branch: MDL-38414_master-fix-behat-test
        diff: https://github.com/dmonllao/moodle/commit/371b7fc397a40f8a65e454df9fe2c4b3d5a7bb56

        Show
        David Monllaó added a comment - The edit course page is currently used to test the "expand all form's fieldsets and advanced elements" step and is breaking the behat tests as it doesn't contain any other advanced fields and 'Show less...' can not be found. Adding a patch on top of integration changing from edit course form to forum form. repo: git://github.com/dmonllao/moodle.git branch: MDL-38414 _master-fix-behat-test diff: https://github.com/dmonllao/moodle/commit/371b7fc397a40f8a65e454df9fe2c4b3d5a7bb56
        Hide
        Damyon Wiese added a comment -

        Thanks David, noting for Fred that his MDL-38012 META issue is likely to cause further behat regressions so he should be testing/fixing behat against each issue.

        Show
        Damyon Wiese added a comment - Thanks David, noting for Fred that his MDL-38012 META issue is likely to cause further behat regressions so he should be testing/fixing behat against each issue.
        Hide
        Damyon Wiese added a comment -

        I have pushed Davids behat fix to master now.

        Show
        Damyon Wiese added a comment - I have pushed Davids behat fix to master now.
        Hide
        Frédéric Massart added a comment -

        Thanks guys, will pay more attention in the future.

        Show
        Frédéric Massart added a comment - Thanks guys, will pay more attention in the future.
        Hide
        Damyon Wiese added a comment -

        This issue has been integrated upstream and is now available via git (and in some hours, via mirrors and downloads).

        Thanks for your contributions!

        Show
        Damyon Wiese added a comment - This issue has been integrated upstream and is now available via git (and in some hours, via mirrors and downloads). Thanks for your contributions!

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            7 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: